From 9f911105fc203639bda40f053bb9da49920d2880 Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Tue, 23 Jan 2024 20:03:06 -0500 Subject: [PATCH 1/3] docs: reviewer and merge process --- .github/CONTRIBUTING.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 3b4e6dd2e7..f4936c4780 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -74,6 +74,16 @@ ensure your pull request matches the style guides, run `npm run prettier`. - Trailing commas, - Avd abbr wrds. +## Review Process + +- Pull requests are required to pass all tests and checks before they can be merged. +- Pull requests should be reviewed by _at least two_ members of the [`@graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged. +- If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql-js-reviewers`. + +## Merge Process + +Once a pull request has been approved by 2 reviewers from [`@graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team, we must wait 2 weeks before merging the pull request, this allows for other reviewers to give feedback without rushing any merges. Pull request can be merged by a member of the [`@graphql-js-reviewers-write`](https://github.com/orgs/graphql/teams/graphql-js-reviewers-write) team. + ## Release on NPM _Only core contributors may release to NPM._ From b7e5b9be5301e931762014cc93def193858d9877 Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Wed, 24 Jan 2024 12:02:21 -0500 Subject: [PATCH 2/3] fix handle --- .github/CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index f4936c4780..841c48b9a4 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -77,12 +77,12 @@ ensure your pull request matches the style guides, run `npm run prettier`. ## Review Process - Pull requests are required to pass all tests and checks before they can be merged. -- Pull requests should be reviewed by _at least two_ members of the [`@graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged. -- If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql-js-reviewers`. +- Pull requests should be reviewed by _at least two_ members of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged. +- If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql/graphql-js-reviewers`. ## Merge Process -Once a pull request has been approved by 2 reviewers from [`@graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team, we must wait 2 weeks before merging the pull request, this allows for other reviewers to give feedback without rushing any merges. Pull request can be merged by a member of the [`@graphql-js-reviewers-write`](https://github.com/orgs/graphql/teams/graphql-js-reviewers-write) team. +Once a pull request has been approved by 2 reviewers from [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team, we must wait 2 weeks before merging the pull request, this allows for other reviewers to give feedback without rushing any merges. Pull request can be merged by a member of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers-write) team. ## Release on NPM From e80d8093141326a24c1486f1a6853ec5e627b25a Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Wed, 24 Jan 2024 12:21:09 -0500 Subject: [PATCH 3/3] Update .github/CONTRIBUTING.md Co-authored-by: Benjie --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 841c48b9a4..58564acdaf 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -77,7 +77,7 @@ ensure your pull request matches the style guides, run `npm run prettier`. ## Review Process - Pull requests are required to pass all tests and checks before they can be merged. -- Pull requests should be reviewed by _at least two_ members of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged. +- Pull requests should be reviewed by _at least two_ members of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged; ideally reviewers affiliated with different organizations - If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql/graphql-js-reviewers`. ## Merge Process