From 3ea06af76a233111eb38df00fed43472ec468640 Mon Sep 17 00:00:00 2001 From: Andrew Levine Date: Tue, 14 Jul 2020 19:06:39 -0500 Subject: [PATCH] Add failing test in findBreakingChanges-test.js --- .../__tests__/findBreakingChanges-test.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/utilities/__tests__/findBreakingChanges-test.js b/src/utilities/__tests__/findBreakingChanges-test.js index 1c5aad92a2..74b7a7193d 100644 --- a/src/utilities/__tests__/findBreakingChanges-test.js +++ b/src/utilities/__tests__/findBreakingChanges-test.js @@ -562,6 +562,24 @@ describe('findBreakingChanges', () => { expect(findBreakingChanges(oldSchema, newSchema)).to.deep.equal([]); }); + it('should not flag args changing from String or Int to ID as breaking', () => { + const oldSchema = buildSchema(` + type Type1 { + field1(arg1: String): Int + field2(arg1: Int): Int + } + `); + + const newSchema = buildSchema(` + type Type1 { + field1(arg1: ID): Int + field2(arg1: ID): Int + } + `); + + expect(findBreakingChanges(oldSchema, newSchema)).to.deep.equal([]); + }); + it('should consider args that move away from NonNull as non-breaking', () => { const oldSchema = buildSchema(` type Type1 {