diff --git a/.eslintrc.yml b/.eslintrc.yml index 1cd056347f..20772a46bf 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -446,7 +446,7 @@ overrides: # Supported Rules # https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#supported-rules '@typescript-eslint/adjacent-overload-signatures': error - '@typescript-eslint/array-type': off # TODO [error, { default: generic }] + '@typescript-eslint/array-type': [error, { default: generic }] '@typescript-eslint/await-thenable': off # TODO error '@typescript-eslint/ban-ts-ignore': error '@typescript-eslint/ban-types': error diff --git a/src/execution/execute.d.ts b/src/execution/execute.d.ts index 19d0b608e8..3514e4696f 100644 --- a/src/execution/execute.d.ts +++ b/src/execution/execute.d.ts @@ -34,7 +34,7 @@ export interface ExecutionContext { operation: OperationDefinitionNode; variableValues: { [key: string]: any }; fieldResolver: GraphQLFieldResolver; - errors: GraphQLError[]; + errors: Array; } export interface ExecutionResultDataDefault { diff --git a/src/language/visitor.d.ts b/src/language/visitor.d.ts index 4bc2d00c05..ffe4a77807 100644 --- a/src/language/visitor.d.ts +++ b/src/language/visitor.d.ts @@ -52,7 +52,7 @@ export type VisitFn = ( export type VisitorKeyMap = { [P in keyof T]: ReadonlyArray }; // TODO: Should be `[]`, but that requires TypeScript@3 -type EmptyTuple = never[]; +type EmptyTuple = Array; export const QueryDocumentKeys: { Name: EmptyTuple; diff --git a/src/type/definition.d.ts b/src/type/definition.d.ts index 66e57fedfd..954c2c7ac1 100644 --- a/src/type/definition.d.ts +++ b/src/type/definition.d.ts @@ -388,10 +388,10 @@ export class GraphQLObjectType< ); getFields(): GraphQLFieldMap; - getInterfaces(): GraphQLInterfaceType[]; + getInterfaces(): Array; toConfig(): GraphQLObjectTypeConfig & { - interfaces: GraphQLInterfaceType[]; + interfaces: Array; fields: GraphQLFieldConfigMap; extensions: Maybe>>; extensionASTNodes: ReadonlyArray; @@ -414,7 +414,7 @@ export interface GraphQLObjectTypeConfig< > { name: string; description?: Maybe; - interfaces?: Thunk>; + interfaces?: Thunk>>; fields: Thunk>; isTypeOf?: Maybe>; extensions?: Maybe>>; @@ -510,7 +510,7 @@ export interface GraphQLField< name: string; description: Maybe; type: GraphQLOutputType; - args: GraphQLArgument[]; + args: Array; resolve?: GraphQLFieldResolver; subscribe?: GraphQLFieldResolver; isDeprecated?: boolean; @@ -567,10 +567,10 @@ export class GraphQLInterfaceType { constructor(config: Readonly>); getFields(): GraphQLFieldMap; - getInterfaces(): GraphQLInterfaceType[]; + getInterfaces(): Array; toConfig(): GraphQLInterfaceTypeConfig & { - interfaces: GraphQLInterfaceType[]; + interfaces: Array; fields: GraphQLFieldConfigMap; extensions: Maybe>>; extensionASTNodes: ReadonlyArray; @@ -589,7 +589,7 @@ export interface GraphQLInterfaceTypeConfig< > { name: string; description?: Maybe; - interfaces?: Thunk>; + interfaces?: Thunk>>; fields: Thunk>; /** * Optionally provide a custom type resolver function. If one is not provided, @@ -634,10 +634,10 @@ export class GraphQLUnionType { extensionASTNodes: Maybe>; constructor(config: Readonly>); - getTypes(): GraphQLObjectType[]; + getTypes(): Array; toConfig(): GraphQLUnionTypeConfig & { - types: GraphQLObjectType[]; + types: Array; extensions: Maybe>>; extensionASTNodes: ReadonlyArray; }; @@ -650,7 +650,7 @@ export class GraphQLUnionType { export interface GraphQLUnionTypeConfig { name: string; description?: Maybe; - types: Thunk; + types: Thunk>; /** * Optionally provide a custom type resolver function. If one is not provided, * the default implementation will call `isTypeOf` on each implementing @@ -691,7 +691,7 @@ export class GraphQLEnumType { extensionASTNodes: Maybe>; constructor(config: Readonly); - getValues(): GraphQLEnumValue[]; + getValues(): Array; getValue(name: string): Maybe; serialize(value: any): Maybe; parseValue(value: any): Maybe; diff --git a/src/type/directives.d.ts b/src/type/directives.d.ts index 93768a6d74..28c70c5045 100644 --- a/src/type/directives.d.ts +++ b/src/type/directives.d.ts @@ -17,9 +17,9 @@ export function assertDirective(directive: any): GraphQLDirective; export class GraphQLDirective { name: string; description: Maybe; - locations: DirectiveLocationEnum[]; + locations: Array; isRepeatable: boolean; - args: GraphQLArgument[]; + args: Array; extensions: Maybe>>; astNode: Maybe; @@ -39,7 +39,7 @@ export class GraphQLDirective { export interface GraphQLDirectiveConfig { name: string; description?: Maybe; - locations: DirectiveLocationEnum[]; + locations: Array; args?: Maybe; isRepeatable?: Maybe; extensions?: Maybe>>; diff --git a/src/type/schema.d.ts b/src/type/schema.d.ts index fd5905125a..c603fd4c41 100644 --- a/src/type/schema.d.ts +++ b/src/type/schema.d.ts @@ -77,8 +77,8 @@ export class GraphQLSchema { getDirective(name: string): Maybe; toConfig(): GraphQLSchemaConfig & { - types: GraphQLNamedType[]; - directives: GraphQLDirective[]; + types: Array; + directives: Array; extensions: Maybe>>; extensionASTNodes: ReadonlyArray; assumeValid: boolean; @@ -107,8 +107,8 @@ export interface GraphQLSchemaConfig extends GraphQLSchemaValidationOptions { query: Maybe; mutation?: Maybe; subscription?: Maybe; - types?: Maybe; - directives?: Maybe; + types?: Maybe>; + directives?: Maybe>; extensions?: Maybe>>; astNode?: Maybe; extensionASTNodes?: Maybe>; diff --git a/src/utilities/findDeprecatedUsages.d.ts b/src/utilities/findDeprecatedUsages.d.ts index 0a55f1b82d..6beb244617 100644 --- a/src/utilities/findDeprecatedUsages.d.ts +++ b/src/utilities/findDeprecatedUsages.d.ts @@ -10,4 +10,4 @@ import { GraphQLSchema } from '../type/schema'; export function findDeprecatedUsages( schema: GraphQLSchema, ast: DocumentNode, -): GraphQLError[]; +): Array; diff --git a/src/validation/validate.d.ts b/src/validation/validate.d.ts index f9781768f6..9230c52814 100644 --- a/src/validation/validate.d.ts +++ b/src/validation/validate.d.ts @@ -41,7 +41,7 @@ export function validateSDL( documentAST: DocumentNode, schemaToExtend?: Maybe, rules?: ReadonlyArray, -): GraphQLError[]; +): Array; /** * Utility function which asserts a SDL document is valid by throwing an error