Skip to content

Extract parser into its own crate #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianks opened this issue Feb 23, 2017 · 7 comments
Closed

Extract parser into its own crate #32

ianks opened this issue Feb 23, 2017 · 7 comments

Comments

@ianks
Copy link

ianks commented Feb 23, 2017

Hey there! I am interested in using the parser from this library in one of my own projects. Would it be possible to extract it into its own crate? Great work on this project, and hope to hear from you soon.

Ian

@mhallin
Copy link
Member

mhallin commented Feb 26, 2017

This would be a nice improvement - not just for the use case of using the parser or type system outside of this project - it would probably cut down on compilation time for the test suite when working on isolated parts.

I imagine looking at the setup used by e.g. gluon would be useful; we probably would want the entire source code to still live in this repository and all released in lockstep with each other.

I'll see what I can do. Hopefully something that can be done before the 1.0 release.

@theduke
Copy link
Member

theduke commented Jul 19, 2017

Now that the repo is restructured, a good next step would be to extract the parser into it's own crate.

@ghost
Copy link

ghost commented Jul 28, 2017

Just had a look at it. It seems the parser depends on the ast. So I guess that has to be moved into the parser.

@naturallymitchell
Copy link

See also graphql-parser which uses pest.

@tailhook
Copy link
Contributor

By the way, is there any reasons why you didn't use a parser library such as combine (the one which I recommend) ? Is there any complexities with the grammar?

@tailhook
Copy link
Contributor

tailhook commented Feb 5, 2018

Everybody watching this issue might be interested in #138

@theduke
Copy link
Member

theduke commented May 16, 2019

Tracked in #138

@theduke theduke closed this as completed May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants