Support time crate types as GraphQL scalars (#1006)

Co-authored-by: Kai Ren <[email protected]>

Author: scott-wilson

README.md

@@ -73,6 +73,7 @@ your Schemas automatically.
 - [url][url]
 - [chrono][chrono]
 - [chrono-tz][chrono-tz]
+- [time][time]
 - [bson][bson]
 
 ### Web Frameworks
@@ -118,5 +119,6 @@ Juniper has not reached 1.0 yet, thus some API instability should be expected.
 [url]: https://crates.io/crates/url
 [chrono]: https://crates.io/crates/chrono
 [chrono-tz]: https://crates.io/crates/chrono-tz
+[time]: https://crates.io/crates/time
 [bson]: https://crates.io/crates/bson
 [juniper-from-schema]: https://github.com/davidpdrsn/juniper-from-schema

docs/book/content/types/scalars.md

@@ -6,11 +6,11 @@ but this often requires coordination with the client library intended to consume
 the API you're building.
 
 Since any value going over the wire is eventually transformed into JSON, you're
-also limited in the data types you can use. 
+also limited in the data types you can use.
 
-There are two ways to define custom scalars. 
+There are two ways to define custom scalars.
 * For simple scalars that just wrap a primitive type, you can use the newtype pattern with
-a custom derive. 
+a custom derive.
 * For more advanced use cases with custom validation, you can use
 the `graphql_scalar` proc macro.
 
@@ -36,12 +36,13 @@ crates. They are enabled via features that are on by default.
 
 * uuid::Uuid
 * chrono::DateTime
+* time::{Date, OffsetDateTime, PrimitiveDateTime, Time, UtcOffset}
 * url::Url
 * bson::oid::ObjectId
 
 ## newtype pattern
 
-Often, you might need a custom scalar that just wraps an existing type. 
+Often, you might need a custom scalar that just wraps an existing type.
 
 This can be done with the newtype pattern and a custom derive, similar to how
 serde supports this pattern with `#[serde(transparent)]`.
@@ -82,15 +83,15 @@ pub struct UserId(i32);
 
 ## Custom scalars
 
-For more complex situations where you also need custom parsing or validation, 
+For more complex situations where you also need custom parsing or validation,
 you can use the `graphql_scalar` proc macro.
 
 Typically, you represent your custom scalars as strings.
 
 The example below implements a custom scalar for a custom `Date` type.
 
-Note: juniper already has built-in support for the `chrono::DateTime` type 
-via `chrono` feature, which is enabled by default and should be used for this 
+Note: juniper already has built-in support for the `chrono::DateTime` type
+via `chrono` feature, which is enabled by default and should be used for this
 purpose.
 
 The example below is used just for illustration.
@@ -101,9 +102,9 @@ The example below is used just for illustration.
 
 ```rust
 # extern crate juniper;
-# mod date { 
-#    pub struct Date; 
-#    impl std::str::FromStr for Date{ 
+# mod date {
+#    pub struct Date;
+#    impl std::str::FromStr for Date {
 #        type Err = String; fn from_str(_value: &str) -> Result<Self, Self::Err> { unimplemented!() }
 #    }
 #    // And we define how to represent date as a string.
@@ -118,7 +119,7 @@ use juniper::{Value, ParseScalarResult, ParseScalarValue};
 use date::Date;
 
 #[juniper::graphql_scalar(description = "Date")]
-impl<S> GraphQLScalar for Date 
+impl<S> GraphQLScalar for Date
 where
     S: ScalarValue
 {

juniper/CHANGELOG.md

@@ -19,6 +19,7 @@
 - Use `null` in addition to `None` to create `Value::Null` in `graphql_value!` macro to mirror `serde_json::json!`. ([#996](https://github.com/graphql-rust/juniper/pull/996))
 - Add `From` impls to `InputValue` mirroring the ones for `Value` and provide better support for `Option` handling. ([#996](https://github.com/graphql-rust/juniper/pull/996))
 - Implement `graphql_input_value!` and `graphql_vars!` macros. ([#996](https://github.com/graphql-rust/juniper/pull/996))
+- Support [`time` crate](https://docs.rs/time) types as GraphQL scalars behind `time` feature. ([#1006](https://github.com/graphql-rust/juniper/pull/1006))
 
 ## Fixes
 

juniper/Cargo.toml

@@ -22,6 +22,7 @@ travis-ci = { repository = "graphql-rust/juniper" }
 default = [
     "bson",
     "chrono",
+    "time",
     "schema-language",
     "url",
     "uuid",
@@ -48,6 +49,7 @@ serde = { version = "1.0.8", features = ["derive"], default-features = false }
 serde_json = { version = "1.0.2", default-features = false, optional = true }
 smartstring = "0.2.6"
 static_assertions = "1.1"
+time = { version = "0.3", features = ["formatting", "macros", "parsing"], optional = true }
 url = { version = "2.0", optional = true }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]

juniper/src/integrations/chrono.rs

@@ -24,9 +24,6 @@ use crate::{
     Value,
 };
 
-#[doc(hidden)]
-pub static RFC3339_FORMAT: &str = "%Y-%m-%dT%H:%M:%S%.f%:z";
-
 #[crate::graphql_scalar(name = "DateTimeFixedOffset", description = "DateTime")]
 impl<S> GraphQLScalar for DateTime<FixedOffset>
 where

juniper/src/integrations/mod.rs

@@ -8,6 +8,8 @@ pub mod chrono;
 pub mod chrono_tz;
 #[doc(hidden)]
 pub mod serde;
+#[cfg(feature = "time")]
+pub mod time;
 #[cfg(feature = "url")]
 pub mod url;
 #[cfg(feature = "uuid")]