Skip to content

Commit e7f7d8d

Browse files
authored
Add missing auto fields (#1212)
* add missing auto fields * add missing auto fields * skip small auto field sometimes * make small auto optional * make small auto optional
1 parent 623d0f2 commit e7f7d8d

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

graphene_django/converter.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,19 @@ def convert_field_to_string(field, registry=None):
166166
)
167167

168168

169+
@convert_django_field.register(models.BigAutoField)
169170
@convert_django_field.register(models.AutoField)
170171
def convert_field_to_id(field, registry=None):
171172
return ID(description=get_django_field_description(field), required=not field.null)
172173

173174

175+
if hasattr(models, "SmallAutoField"):
176+
177+
@convert_django_field.register(models.SmallAutoField)
178+
def convert_field_small_to_id(field, registry=None):
179+
return convert_field_to_id(field, registry)
180+
181+
174182
@convert_django_field.register(models.UUIDField)
175183
def convert_field_to_uuid(field, registry=None):
176184
return UUID(

graphene_django/tests/test_converter.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,15 @@ def test_should_auto_convert_id():
111111
assert_conversion(models.AutoField, graphene.ID, primary_key=True)
112112

113113

114+
def test_should_big_auto_convert_id():
115+
assert_conversion(models.BigAutoField, graphene.ID, primary_key=True)
116+
117+
118+
def test_should_small_auto_convert_id():
119+
if hasattr(models, "SmallAutoField"):
120+
assert_conversion(models.SmallAutoField, graphene.ID, primary_key=True)
121+
122+
114123
def test_should_uuid_convert_id():
115124
assert_conversion(models.UUIDField, graphene.UUID)
116125

0 commit comments

Comments
 (0)