Skip to content

Too described logging on transport level. #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mangin opened this issue Mar 29, 2023 · 3 comments
Closed

Too described logging on transport level. #400

mangin opened this issue Mar 29, 2023 · 3 comments
Labels
type: question or discussion Issue discussing or asking a question about gql

Comments

@mangin
Copy link

mangin commented Mar 29, 2023

Hey there,
I think we have a problem here:
https://github.com/graphql-python/gql/blob/master/gql/transport/aiohttp.py#L333

We writes too many logs on info level.
Maybe we should log them only on debug level?

I know that it's possible to tune it on application level.
But still for me it's a real big surprise that gql library writes so many logs by default.

WDYT?

@mangin
Copy link
Author

mangin commented Mar 29, 2023

#401

@leszekhanusz
Copy link
Collaborator

Sorry, this can't be changed as it is a breaking change.
See Disabling-logs in the docs to modify the log level for gql.

@leszekhanusz leszekhanusz added the type: question or discussion Issue discussing or asking a question about gql label Mar 29, 2023
@mangin
Copy link
Author

mangin commented Mar 29, 2023

Maybe we can change it in the future releases?

now it's a really verbose. And i don't think that everyone knows how to disable logs and would find this article.
Thank you for your reply:

But it could create some problem for production systems. Because now this module generates a lot of logs => someone pays for it => wasting of planet resources (it's a small joke already)

P.S. for my-own project I already disabled it. But yep it's the first library in my life that logs all traffic by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about gql
Projects
None yet
Development

No branches or pull requests

2 participants