Skip to content

Commit f759b34

Browse files
committed
Tweaked readme - streamUsersById renamed
1 parent d0820fc commit f759b34

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ A `org.dataloader.BatchPublisher` may be used to load this data:
299299
BatchPublisher<Long, User> batchPublisher = new BatchPublisher<Long, User>() {
300300
@Override
301301
public void load(List<Long> userIds, Subscriber<User> userSubscriber) {
302-
Publisher<User> userResults = userManager.publishUsersById(userIds);
302+
Publisher<User> userResults = userManager.streamUsersById(userIds);
303303
userResults.subscribe(userSubscriber);
304304
}
305305
};
@@ -340,7 +340,7 @@ In instances like these, `org.dataloader.MappedBatchPublisher` can be used.
340340
MappedBatchPublisher<Long, User> mappedBatchPublisher = new MappedBatchPublisher<Long, User>() {
341341
@Override
342342
public void load(Set<Long> userIds, Subscriber<Map.Entry<Long, User>> userEntrySubscriber) {
343-
Publisher<Map.Entry<Long, User>> userEntries = userManager.publishUsersById(userIds);
343+
Publisher<Map.Entry<Long, User>> userEntries = userManager.streamUsersById(userIds);
344344
userEntries.subscribe(userEntrySubscriber);
345345
}
346346
};

src/test/java/ReadmeExamples.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.dataloader.stats.ThreadLocalStatisticsCollector;
2020
import org.reactivestreams.Publisher;
2121
import org.reactivestreams.Subscriber;
22-
import reactor.core.publisher.Flux;
2322

2423
import java.time.Duration;
2524
import java.util.ArrayList;
@@ -196,7 +195,7 @@ private void batchPublisher() {
196195
BatchPublisher<Long, User> batchPublisher = new BatchPublisher<Long, User>() {
197196
@Override
198197
public void load(List<Long> userIds, Subscriber<User> userSubscriber) {
199-
Publisher<User> userResults = userManager.publishUsersById(userIds);
198+
Publisher<User> userResults = userManager.streamUsersById(userIds);
200199
userResults.subscribe(userSubscriber);
201200
}
202201
};
@@ -207,7 +206,7 @@ private void mappedBatchPublisher() {
207206
MappedBatchPublisher<Long, User> mappedBatchPublisher = new MappedBatchPublisher<Long, User>() {
208207
@Override
209208
public void load(Set<Long> userIds, Subscriber<Map.Entry<Long, User>> userEntrySubscriber) {
210-
Publisher<Map.Entry<Long, User>> userEntries = userManager.publishUsersById(userIds);
209+
Publisher<Map.Entry<Long, User>> userEntries = userManager.streamUsersById(userIds);
211210
userEntries.subscribe(userEntrySubscriber);
212211
}
213212
};

src/test/java/org/dataloader/fixtures/UserManager.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.dataloader.fixtures;
22

33
import org.reactivestreams.Publisher;
4-
import org.reactivestreams.Subscriber;
54
import reactor.core.publisher.Flux;
65

76
import java.util.HashMap;
@@ -56,11 +55,11 @@ public List<User> loadUsersById(List<Long> userIds) {
5655
return userIds.stream().map(this::loadUserById).collect(Collectors.toList());
5756
}
5857

59-
public Publisher<User> publishUsersById(List<Long> userIds) {
58+
public Publisher<User> streamUsersById(List<Long> userIds) {
6059
return Flux.fromIterable(loadUsersById(userIds));
6160
}
6261

63-
public Publisher<Map.Entry<Long, User>> publishUsersById(Set<Long> userIds) {
62+
public Publisher<Map.Entry<Long, User>> streamUsersById(Set<Long> userIds) {
6463
return Flux.fromIterable(loadMapOfUsersByIds(null, userIds).entrySet());
6564
}
6665

0 commit comments

Comments
 (0)