Skip to content

Update rule suitability to schema build time when graphql-java is fixed upstream #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbakerman opened this issue Oct 6, 2020 · 2 comments

Comments

@bbakerman
Copy link
Member

#17 and #30 moved the "suitability check" of a rule to DataFectehr runtime to work around a problem in SchemaDirectiveWiring when the true schema is not built at the time it is called back.

The workaround means that the DataFetcher is not as fast as it could be on 1st access.

We need to move back to early rule suitability checks at schema build time to ensure the most performant system.

This can only be done once graphql-java is fixed

See graphql-java/graphql-java#2070

@setchy setchy modified the milestone: 16.x Jan 27, 2021
@setchy
Copy link
Collaborator

setchy commented Feb 2, 2021

I noticed the upstream bug graphql-java/graphql-java#2070 has been resolved in v16.x

@dondonz
Copy link
Member

dondonz commented Nov 13, 2022

Closing this issue as graphql-java/graphql-java#2070 has been fixed and the version in this repo has been updated.

@dondonz dondonz closed this as completed Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants