From 60065bb1d8467d45bdc6941c8d539534ad9c5fd9 Mon Sep 17 00:00:00 2001
From: Laurence Gonsalves <laurence@xenomachina.com>
Date: Mon, 11 Oct 2021 17:05:59 -0700
Subject: [PATCH] Update primitive type descriptions

The type descriptions were previously inconsistent (eg: Long's was "Long
type", while Short's was "Short as Int"), and unhelpful to clients that
aren't familiar with Java's type system (eg: "Short" may have no meaning
to a JavaScript programmer, nor would "java.math.BigInteger")

This change attempts to make the descriptions more consistent and also
programming language agnostic.
---
 .../java/graphql/scalars/java/JavaPrimitives.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/graphql/scalars/java/JavaPrimitives.java b/src/main/java/graphql/scalars/java/JavaPrimitives.java
index 42392cf..75a0ddf 100644
--- a/src/main/java/graphql/scalars/java/JavaPrimitives.java
+++ b/src/main/java/graphql/scalars/java/JavaPrimitives.java
@@ -123,7 +123,7 @@ public Value<?> valueToLiteral(Object input) {
         };
 
         GraphQLLong = GraphQLScalarType.newScalar()
-                .name("Long").description("Long type")
+                .name("Long").description("A 64-bit signed integer")
                 .coercing(longCoercing).build();
     }
 
@@ -202,7 +202,7 @@ public Value<?> valueToLiteral(Object input) {
         };
 
         GraphQLShort = GraphQLScalarType.newScalar()
-                .name("Short").description("Short as Int")
+                .name("Short").description("A 16-bit signed integer")
                 .coercing(shortCoercing).build();
     }
 
@@ -281,7 +281,7 @@ public Value<?> valueToLiteral(Object input) {
         };
 
         GraphQLByte = GraphQLScalarType.newScalar()
-                .name("Byte").description("Byte as Int")
+                .name("Byte").description("An 8-bit signed integer")
                 .coercing(byteCoercing).build();
     }
 
@@ -368,7 +368,7 @@ public Value<?> valueToLiteral(Object input) {
         };
 
         GraphQLBigInteger = GraphQLScalarType.newScalar()
-                .name("BigInteger").description("java.math.BigInteger")
+                .name("BigInteger").description("An arbitrary precision signed integer")
                 .coercing(bigIntCoercing).build();
     }
 
@@ -443,7 +443,7 @@ public Value<?> valueToLiteral(Object input) {
         };
 
         GraphQLBigDecimal = GraphQLScalarType.newScalar()
-                .name("BigDecimal").description("java.math.BigDecimal")
+                .name("BigDecimal").description("An arbitrary precision signed decimal")
                 .coercing(bigDecimalCoercing).build();
     }
 
@@ -514,7 +514,7 @@ public Value<?> valueToLiteral(Object input) {
         };
 
         GraphQLChar = GraphQLScalarType.newScalar()
-                .name("Char").description("Char as Character")
+                .name("Char").description("A UTF-16 code unit; a character on Unicode's BMP")
                 .coercing(characterCoercing).build();
     }
 }