Skip to content

graphql.servlet package not being exported in OSGI environment #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aznguy opened this issue Feb 19, 2020 · 3 comments
Closed

graphql.servlet package not being exported in OSGI environment #232

aznguy opened this issue Feb 19, 2020 · 3 comments

Comments

@aznguy
Copy link

aznguy commented Feb 19, 2020

Recently I've migrated from release 8.0.0 to 9.0.1 due to some bugs that have been fixed in that release. (#196)
There are some changes made in the organization of the project. Which is fine but I encountered some problems.

What I've discovered is that the graphql.servlet package has been movedfrom Export-Package to Private-package. I was wondering is was done intentionally.

Version 9.0.1 META-INF/MANIFEST.MF:
Private-Package: graphql.servlet,graphql.servlet.apollo,graphql.servle t.config,graphql.servlet.context,graphql.servlet.core,graphql.servlet .core.internal,graphql.servlet.input,graphql.servlet.osgi,graphql.ser vlet.subscriptions ...
VS

Version 8.0.0 META-INF/MANIFEST.MF:
Export-Package: graphql.servlet;version="8.0.0";uses:="graphql.executi on.preparsed,graphql.schema,graphql.servlet.config,graphql.servlet.co ntext,graphql.servlet.core,graphql.servlet.input,javax.servlet,javax. servlet ....

Because of this I'm getting the error that osgi.wiring.package=graphqlservlet cannot be found. during the build of my OSGI Environment.

Please let me know if more information is needed or how to tackle this problem.

Best regards,
Aznguy

@oliemansm
Copy link
Member

I'm not familiar with OSGI tbh, and also haven't changed that myself. Can you see how that was changed? Are you able to create a PR for it to fix it?

@benfortuna
Copy link
Contributor

I've just added a PR that should fix this: #236

@aznguy
Copy link
Author

aznguy commented Mar 11, 2020

Ah cool Thanks @benfortuna!,

I also managed to get it working locally. But unfortunately I´m behind cooperate firewall which restricts me from pushing to remote.

@aznguy aznguy closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants