Skip to content

Commit 00daa50

Browse files
Merge pull request #547 from graphql-java-kickstart/rebase-jakarta5-branch
chore: align jakarta5 branch to master
2 parents 72fba8b + ce19b1b commit 00daa50

File tree

9 files changed

+79
-42
lines changed

9 files changed

+79
-42
lines changed

.github/workflows/pull-request.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
name: Gradle Wrapper Validation
99
runs-on: ubuntu-latest
1010
steps:
11-
- uses: actions/checkout@v3
11+
- uses: actions/checkout@v4
1212
- uses: gradle/wrapper-validation-action@v1
1313

1414
test:
@@ -22,9 +22,9 @@ jobs:
2222
runs-on: ${{ matrix.os }}
2323
steps:
2424
- name: Checkout
25-
uses: actions/checkout@v3
25+
uses: actions/checkout@v4
2626
- name: Setup Java
27-
uses: actions/setup-java@v3
27+
uses: actions/setup-java@v4
2828
with:
2929
distribution: 'zulu'
3030
java-version: ${{ matrix.java }}
@@ -56,13 +56,13 @@ jobs:
5656
env:
5757
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
5858
steps:
59-
- uses: actions/checkout@v3
59+
- uses: actions/checkout@v4
6060
if: env.SONAR_TOKEN != null
6161
with:
6262
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
6363
- name: Set up JDK 17
6464
if: env.SONAR_TOKEN != null
65-
uses: actions/setup-java@v3
65+
uses: actions/setup-java@v4
6666
with:
6767
distribution: 'zulu'
6868
java-version: 17

.github/workflows/release.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@ jobs:
66
name: Gradle Wrapper Validation
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/checkout@v3
9+
- uses: actions/checkout@v4
1010
- uses: gradle/wrapper-validation-action@v1
1111

12-
test-jakarta5:
12+
test-jakarta:
1313
name: Test run jakarta
1414
needs: validation
1515
runs-on: ubuntu-latest
1616
steps:
1717
- name: Checkout
18-
uses: actions/checkout@v3
18+
uses: actions/checkout@v4
1919
- name: Setup Java
20-
uses: actions/setup-java@v3
20+
uses: actions/setup-java@v4
2121
with:
2222
distribution: 'zulu'
2323
java-version: 17
@@ -43,9 +43,9 @@ jobs:
4343
runs-on: ubuntu-latest
4444
steps:
4545
- name: Checkout
46-
uses: actions/checkout@v3
46+
uses: actions/checkout@v4
4747
- name: Setup Java
48-
uses: actions/setup-java@v3
48+
uses: actions/setup-java@v4
4949
with:
5050
distribution: 'zulu'
5151
java-version: 17

.github/workflows/snapshot.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
name: Gradle Wrapper Validation
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@v3
12+
- uses: actions/checkout@v4
1313
- uses: gradle/wrapper-validation-action@v1
1414

1515
test-jakarta5:
@@ -18,9 +18,9 @@ jobs:
1818
runs-on: ubuntu-latest
1919
steps:
2020
- name: Checkout
21-
uses: actions/checkout@v3
21+
uses: actions/checkout@v4
2222
- name: Setup Java
23-
uses: actions/setup-java@v3
23+
uses: actions/setup-java@v4
2424
with:
2525
distribution: 'zulu'
2626
java-version: 17
@@ -46,9 +46,9 @@ jobs:
4646
runs-on: ubuntu-latest
4747
steps:
4848
- name: Checkout
49-
uses: actions/checkout@v3
49+
uses: actions/checkout@v4
5050
- name: Setup Java
51-
uses: actions/setup-java@v3
51+
uses: actions/setup-java@v4
5252
with:
5353
distribution: 'zulu'
5454
java-version: 17
@@ -77,11 +77,11 @@ jobs:
7777
needs: validation
7878
runs-on: ubuntu-latest
7979
steps:
80-
- uses: actions/checkout@v3
80+
- uses: actions/checkout@v4
8181
with:
8282
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
8383
- name: Set up JDK 17
84-
uses: actions/setup-java@v3
84+
uses: actions/setup-java@v4
8585
with:
8686
distribution: 'zulu'
8787
java-version: 17

README.md

+44-8
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,53 @@ regarding GraphQL Java itself.
2222
We try to stay up to date with GraphQL Java as much as possible maintaining the retro-compatibility
2323
with javax and Springframework 5.
2424

25-
On each release we publish two flavours of this project:
26-
- the main one is using `jakarta` and Springframework `6.*`
27-
- the legacy one is using `javax` and Springframework `5.*`
25+
On each release we publish three flavours of this project:
26+
- [latest jakarta](#jakarta-and-springframework-6)
27+
- [jakarta5](#jakarta5)
28+
- [javax](#javax-and-springframework-5)
29+
30+
All of them also supports legacy projects that can compile with older JDK versions: the minimum JDK
31+
version supported is the `11`.
2832

29-
On maven central you can distinguish them from the version because the `javax` flavor has the
30-
suffix `-javax`.
33+
## Jakarta and Springframework 6.*
34+
This is the main flavour using the latest version of `Jakarta` (currently the `6.*`) and the latest
35+
version of `Springframework` (currently the `6.*`). All the codebase can be found in the branch:
36+
`master`
3137

32-
Both of them also supports legacy projects that can compile with older JDK versions: the oldest
33-
supported one is the `11`.
38+
```xml
39+
<dependency>
40+
<groupId>com.graphql-java-kickstart</groupId>
41+
<artifactId>graphql-java-servlet</artifactId>
42+
<version>${graphql-java-servlet.version}</version>
43+
</dependency>
44+
```
45+
46+
## Jakarta5
47+
This flavour use the `jakarta` version `5.*` and it is meant to be used for all the projects that
48+
are already migrated to jakarta, but they are waiting that `jakarta6` will become more broadly used.
49+
All the codebase can be found in the branch: `jakarta5`
50+
51+
```xml
52+
<dependency>
53+
<groupId>com.graphql-java-kickstart</groupId>
54+
<artifactId>graphql-java-servlet-jakarta5</artifactId>
55+
<version>${graphql-java-servlet-jakarta5.version}</version>
56+
</dependency>
57+
```
58+
59+
## Javax and Springframework 5.*
60+
This is the legacy flavour using the `javax` dependency and the version `5.*` of `Springframework`
61+
(since it is still broadly used by a lot of projects). All the codebase can be found in the branch:
62+
`master`
63+
64+
```xml
65+
<dependency>
66+
<groupId>com.graphql-java-kickstart</groupId>
67+
<artifactId>graphql-java-servlet-javax</artifactId>
68+
<version>${graphql-java-servlet.version}</version>
69+
</dependency>
70+
```
3471

35-
See [gradle.properties](gradle.properties) to see currently supported versions.
3672

3773
## Installation and getting started
3874

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ buildscript {
2828

2929
plugins {
3030
id "biz.aQute.bnd.builder" version "6.4.0" apply false
31-
id "org.sonarqube" version "4.2.1.3168"
31+
id "org.sonarqube" version "4.4.1.3373"
3232
id "jacoco"
3333
id "io.github.gradle-nexus.publish-plugin" version '1.3.0'
3434
}

gradle.properties

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ PROJECT_LICENSE=MIT
77
PROJECT_LICENSE_URL=https://github.com/graphql-java-kickstart/spring-java-servlet/blob/master/LICENSE.md
88
PROJECT_DEV_ID=oliemansm
99
PROJECT_DEV_NAME=Michiel Oliemans
10-
LIB_GRAPHQL_JAVA_VER=20.4
11-
LIB_JACKSON_VER=2.15.2
12-
LIB_SLF4J_VER=2.0.7
13-
LIB_LOMBOK_VER=1.18.28
10+
LIB_GRAPHQL_JAVA_VER=21.3
11+
LIB_JACKSON_VER=2.16.1
12+
LIB_SLF4J_VER=2.0.9
13+
LIB_LOMBOK_VER=1.18.30
1414
# These constants are necessary to the automatic release of javax flavour
1515
LIB_JAVAX_SERVLET=4.0.1
1616
LIB_JAVAX_WEBSOCKET=1.1
+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-all.zip
44
networkTimeout=10000
5+
validateDistributionUrl=true
56
zipStoreBase=GRADLE_USER_HOME
67
zipStorePath=wrapper/dists

graphql-java-kickstart/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ dependencies {
1414
// JSON
1515
api "com.fasterxml.jackson.core:jackson-core:$LIB_JACKSON_VER"
1616
api "com.fasterxml.jackson.core:jackson-annotations:$LIB_JACKSON_VER"
17-
api "com.fasterxml.jackson.core:jackson-databind:2.15.2"
17+
api "com.fasterxml.jackson.core:jackson-databind:2.16.1"
1818
api "com.fasterxml.jackson.datatype:jackson-datatype-jdk8:$LIB_JACKSON_VER"
1919
}

graphql-java-servlet/build.gradle

+9-9
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ dependencies {
1717

1818
// Servlet
1919
compileOnly "jakarta.servlet:jakarta.servlet-api:5.0.0"
20-
compileOnly "jakarta.websocket:jakarta.websocket-api:2.1.0"
21-
compileOnly "jakarta.websocket:jakarta.websocket-client-api:2.1.0"
20+
compileOnly "jakarta.websocket:jakarta.websocket-api:2.1.1"
21+
compileOnly "jakarta.websocket:jakarta.websocket-client-api:2.1.1"
2222
implementation "org.slf4j:slf4j-api:$LIB_SLF4J_VER"
2323

2424
// OSGi
@@ -32,15 +32,15 @@ dependencies {
3232
testImplementation 'io.github.graphql-java:graphql-java-annotations:9.1'
3333

3434
// Unit testing
35-
testImplementation "org.apache.groovy:groovy-all:4.0.12"
35+
testImplementation "org.apache.groovy:groovy-all:4.0.17"
3636
testImplementation "org.spockframework:spock-core:2.3-groovy-4.0"
37-
testRuntimeOnly "cglib:cglib-nodep:3.3.0"
37+
testRuntimeOnly "net.bytebuddy:byte-buddy:1.14.11"
3838
testRuntimeOnly "org.objenesis:objenesis:3.3"
3939
testImplementation "org.slf4j:slf4j-simple:$LIB_SLF4J_VER"
40-
testImplementation "org.springframework:spring-test:6.0.10"
41-
testRuntimeOnly "org.springframework:spring-web:6.0.10"
42-
testImplementation 'com.google.guava:guava:32.0.1-jre'
40+
testImplementation "org.springframework:spring-test:6.1.2"
41+
testRuntimeOnly "org.springframework:spring-web:6.1.2"
42+
testImplementation 'com.google.guava:guava:33.0.0-jre'
4343
testImplementation "jakarta.servlet:jakarta.servlet-api:6.0.0"
44-
testImplementation "jakarta.websocket:jakarta.websocket-api:2.1.0"
45-
testImplementation "jakarta.websocket:jakarta.websocket-client-api:2.1.0"
44+
testImplementation "jakarta.websocket:jakarta.websocket-api:2.1.1"
45+
testImplementation "jakarta.websocket:jakarta.websocket-client-api:2.1.1"
4646
}

0 commit comments

Comments
 (0)