Skip to content

Commit e36ba0a

Browse files
authored
Merge pull request #2463 from Urigo/no-asynchooks-docs
Update docs #2461
2 parents f3e0750 + b8e2d1d commit e36ba0a

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

website/src/pages/docs/advanced/execution-context.mdx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,3 @@ The next lines show the usage of `@ExecutionContext` decorator. It's a property
3838
This way the Singleton `Data` service runs within the execution context of a GraphQL Operation and can access Operation scoped Injector and the GraphQL Context object.
3939

4040
It also means you gain a lot in terms of performance because the `Data` class is instantiated only once and used in many operations.
41-
42-
<Callout>
43-
`@ExecutionContext` impacts the performance, depending on your Node version
44-
(execution context uses `async_hooks` module).
45-
46-
GraphQL Modules is smart enough to enable `async_hooks` only when
47-
`@ExecutionContext` is used.
48-
49-
</Callout>

website/src/pages/docs/recipes/migration.mdx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,6 @@ export class MyProvider {
317317

318318
In v0, we had a concept of Session to manage the execution of each operation. In v1, we dropped it, in favor of a simpler solution.
319319

320-
Internally, we are using Node's `async_hooks` to manage a context of an execution, which allow us to share Injectables between Singleton and Operation scope.
321-
322320
## Context
323321

324322
In v0, you could create a `context` per each module. In v1, `context` is external for GraphQL-Modules and it's not directly in use. You can do whatever you want with that, and just access it in GraphQL-Modules if you need, but we no longer require you to do specific things with your `context`.

0 commit comments

Comments
 (0)