nullable reference types support (#65)

Author: sungam3r

appveyor.yml

@@ -1,4 +1,4 @@
-version: 5.1.0.{build}
+version: 5.1.1.{build}
 pull_requests:
   do_not_increment_build_number: true
 skip_tags: true

package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphql-parser",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "main": "index.js",
   "repository": "[email protected]:graphql-dotnet/parser.git",
   "author": "Joe McBride",

src/Directory.Build.props

@@ -1,12 +1,13 @@
 <Project>
 
   <PropertyGroup>
-    <VersionPrefix>5.1.0</VersionPrefix>
+    <VersionPrefix>5.1.1</VersionPrefix>
     <Authors>Marek Magdziak</Authors>
     <NoWarn>$(NoWarn);1591</NoWarn>
     <Copyright>Copyright 2016-2020 Marek Magdziak et al. All rights reserved.</Copyright>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
     <LangVersion>latest</LangVersion>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
 </Project>

src/GraphQLParser.ApiTests/ApiApprovalTests.Public_Api_Should_Not_Change_Inadvertently.approved.txt

@@ -7,8 +7,8 @@ namespace GraphQLParser.Benchmarks
     [RPlotExporter, CsvMeasurementsExporter]
     public class ParserBenchmark
     {
-        private ILexemeCache _serial;
-        private ILexemeCache _concurrent;
+        private ILexemeCache? _serial;
+        private ILexemeCache? _concurrent;
 
         [GlobalSetup]
         public void GlobalSetup()

src/GraphQLParser.Benchmarks/ParserBenchmark.cs

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
-    <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
+    <Nullable>disable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

src/GraphQLParser.Tests/GraphQLParser.Tests.csproj

@@ -6,6 +6,6 @@ public abstract class ASTNode
 
         public GraphQLLocation Location { get; set; }
 
-        public GraphQLComment Comment { get; set; }
+        public GraphQLComment? Comment { get; set; }
     }
 }

src/GraphQLParser/AST/ASTNode.cs

@@ -4,8 +4,8 @@ public class GraphQLArgument : ASTNode, INamedNode
     {
         public override ASTNodeKind Kind => ASTNodeKind.Argument;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
 
-        public GraphQLValue Value { get; set; }
+        public GraphQLValue? Value { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLArgument.cs

@@ -4,10 +4,10 @@ namespace GraphQLParser.AST
 {
     public class GraphQLDirective : ASTNode, INamedNode
     {
-        public List<GraphQLArgument> Arguments { get; set; }
+        public List<GraphQLArgument>? Arguments { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.Directive;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLDirective.cs

@@ -4,13 +4,13 @@
 
     public class GraphQLDirectiveDefinition : GraphQLTypeDefinition
     {
-        public List<GraphQLInputValueDefinition> Arguments { get; set; }
+        public List<GraphQLInputValueDefinition>? Arguments { get; set; }
 
-        public List<GraphQLInputValueDefinition> Definitions { get; set; }
+        public List<GraphQLInputValueDefinition>? Definitions { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.DirectiveDefinition;
 
-        public List<GraphQLName> Locations { get; set; }
+        public List<GraphQLName>? Locations { get; set; }
 
         public bool Repeatable { get; set; }
     }

src/GraphQLParser/AST/GraphQLDirectiveDefinition.cs

@@ -4,7 +4,7 @@ namespace GraphQLParser.AST
 {
     public class GraphQLDocument : ASTNode
     {
-        public List<ASTNode> Definitions { get; set; }
+        public List<ASTNode>? Definitions { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.Document;
     }

src/GraphQLParser/AST/GraphQLDocument.cs

@@ -4,10 +4,10 @@ namespace GraphQLParser.AST
 {
     public class GraphQLEnumTypeDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.EnumTypeDefinition;
 
-        public List<GraphQLEnumValueDefinition> Values { get; set; }
+        public List<GraphQLEnumValueDefinition>? Values { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLEnumTypeDefinition.cs

@@ -4,7 +4,7 @@ namespace GraphQLParser.AST
 {
     public class GraphQLEnumValueDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.EnumValueDefinition;
     }

src/GraphQLParser/AST/GraphQLEnumValueDefinition.cs

@@ -4,12 +4,12 @@ namespace GraphQLParser.AST
 {
     public class GraphQLFieldDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLInputValueDefinition> Arguments { get; set; }
+        public List<GraphQLInputValueDefinition>? Arguments { get; set; }
 
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.FieldDefinition;
 
-        public GraphQLType Type { get; set; }
+        public GraphQLType? Type { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLFieldDefinition.cs

@@ -4,16 +4,16 @@ namespace GraphQLParser.AST
 {
     public class GraphQLFieldSelection : ASTNode, IHasDirectivesNode, INamedNode
     {
-        public GraphQLName Alias { get; set; }
+        public GraphQLName? Alias { get; set; }
 
-        public List<GraphQLArgument> Arguments { get; set; }
+        public List<GraphQLArgument>? Arguments { get; set; }
 
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.Field;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
 
-        public GraphQLSelectionSet SelectionSet { get; set; }
+        public GraphQLSelectionSet? SelectionSet { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLFieldSelection.cs

@@ -4,6 +4,6 @@ public class GraphQLFragmentDefinition : GraphQLInlineFragment, INamedNode
     {
         public override ASTNodeKind Kind => ASTNodeKind.FragmentDefinition;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLFragmentDefinition.cs

@@ -4,10 +4,10 @@ namespace GraphQLParser.AST
 {
     public class GraphQLFragmentSpread : ASTNode, IHasDirectivesNode, INamedNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.FragmentSpread;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLFragmentSpread.cs

@@ -4,12 +4,12 @@
 
     public class GraphQLInlineFragment : ASTNode, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.InlineFragment;
 
-        public GraphQLSelectionSet SelectionSet { get; set; }
+        public GraphQLSelectionSet? SelectionSet { get; set; }
 
-        public GraphQLNamedType TypeCondition { get; set; }
+        public GraphQLNamedType? TypeCondition { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLInlineFragment.cs

@@ -4,9 +4,9 @@
 
     public class GraphQLInputObjectTypeDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
-        public List<GraphQLInputValueDefinition> Fields { get; set; }
+        public List<GraphQLInputValueDefinition>? Fields { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.InputObjectTypeDefinition;
     }

src/GraphQLParser/AST/GraphQLInputObjectTypeDefinition.cs

@@ -4,12 +4,12 @@ namespace GraphQLParser.AST
 {
     public class GraphQLInputValueDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public GraphQLValue DefaultValue { get; set; }
+        public GraphQLValue? DefaultValue { get; set; }
 
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.InputValueDefinition;
 
-        public GraphQLType Type { get; set; }
+        public GraphQLType? Type { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLInputValueDefinition.cs

@@ -4,9 +4,9 @@ namespace GraphQLParser.AST
 {
     public class GraphQLInterfaceTypeDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
-        public List<GraphQLFieldDefinition> Fields { get; set; }
+        public List<GraphQLFieldDefinition>? Fields { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.InterfaceTypeDefinition;
     }

src/GraphQLParser/AST/GraphQLInterfaceTypeDefinition.cs

@@ -4,7 +4,7 @@ public class GraphQLListType : GraphQLType
     {
         public override ASTNodeKind Kind => ASTNodeKind.ListType;
 
-        public GraphQLType Type { get; set; }
+        public GraphQLType? Type { get; set; }
 
         public override string ToString() => $"[{Type}]";
     }

src/GraphQLParser/AST/GraphQLListType.cs

@@ -11,12 +11,12 @@ public GraphQLListValue(ASTNodeKind kind)
             kindField = kind;
         }
 
-        public string AstValue { get; set; }
+        public string? AstValue { get; set; }
 
         public override ASTNodeKind Kind => kindField;
 
-        public List<GraphQLValue> Values { get; set; }
+        public List<GraphQLValue>? Values { get; set; }
 
-        public override string ToString() => AstValue;
+        public override string ToString() => AstValue!;
     }
 }

src/GraphQLParser/AST/GraphQLListValue.cs

@@ -7,6 +7,6 @@ public class GraphQLName : ASTNode
     {
         public override ASTNodeKind Kind => ASTNodeKind.Name;
 
-        public string Value { get; set; }
+        public string? Value { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLName.cs

@@ -4,8 +4,8 @@ public class GraphQLNamedType : GraphQLType, INamedNode
     {
         public override ASTNodeKind Kind => ASTNodeKind.NamedType;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
 
-        public override string ToString() => Name.Value;
+        public override string ToString() => Name?.Value!;
     }
 }

src/GraphQLParser/AST/GraphQLNamedType.cs

@@ -4,7 +4,7 @@ public class GraphQLNonNullType : GraphQLType
     {
         public override ASTNodeKind Kind => ASTNodeKind.NonNullType;
 
-        public GraphQLType Type { get; set; }
+        public GraphQLType? Type { get; set; }
 
         public override string ToString() => Type + "!";
     }

src/GraphQLParser/AST/GraphQLNonNullType.cs

@@ -4,8 +4,8 @@ public class GraphQLObjectField : ASTNode, INamedNode
     {
         public override ASTNodeKind Kind => ASTNodeKind.ObjectField;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
 
-        public GraphQLValue Value { get; set; }
+        public GraphQLValue? Value { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLObjectField.cs

@@ -4,11 +4,11 @@ namespace GraphQLParser.AST
 {
     public class GraphQLObjectTypeDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
-        public List<GraphQLFieldDefinition> Fields { get; set; }
+        public List<GraphQLFieldDefinition>? Fields { get; set; }
 
-        public List<GraphQLNamedType> Interfaces { get; set; }
+        public List<GraphQLNamedType>? Interfaces { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.ObjectTypeDefinition;
     }

src/GraphQLParser/AST/GraphQLObjectTypeDefinition.cs

@@ -4,7 +4,7 @@ namespace GraphQLParser.AST
 {
     public class GraphQLObjectValue : GraphQLValue
     {
-        public List<GraphQLObjectField> Fields { get; set; }
+        public List<GraphQLObjectField>? Fields { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.ObjectValue;
     }

src/GraphQLParser/AST/GraphQLObjectValue.cs

@@ -4,16 +4,16 @@ namespace GraphQLParser.AST
 {
     public class GraphQLOperationDefinition : ASTNode, IHasDirectivesNode, INamedNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.OperationDefinition;
 
-        public GraphQLName Name { get; set; }
+        public GraphQLName? Name { get; set; }
 
         public OperationType Operation { get; set; }
 
-        public GraphQLSelectionSet SelectionSet { get; set; }
+        public GraphQLSelectionSet? SelectionSet { get; set; }
 
-        public List<GraphQLVariableDefinition> VariableDefinitions { get; set; }
+        public List<GraphQLVariableDefinition>? VariableDefinitions { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLOperationDefinition.cs

@@ -6,6 +6,6 @@ public class GraphQLOperationTypeDefinition : ASTNode
 
         public OperationType Operation { get; set; }
 
-        public GraphQLNamedType Type { get; set; }
+        public GraphQLNamedType? Type { get; set; }
     }
 }

src/GraphQLParser/AST/GraphQLOperationTypeDefinition.cs

@@ -4,7 +4,7 @@ namespace GraphQLParser.AST
 {
     public class GraphQLScalarTypeDefinition : GraphQLTypeDefinition, IHasDirectivesNode
     {
-        public List<GraphQLDirective> Directives { get; set; }
+        public List<GraphQLDirective>? Directives { get; set; }
 
         public override ASTNodeKind Kind => ASTNodeKind.ScalarTypeDefinition;
     }