Merge pull request #369 from graphql-dotnet/fix-di

rose-a · web-flow · commit 8cbe46ed4b2b · 2021-10-31T09:29:00.000+01:00
Fix for double instantiation of GraphQLLocalExecutionClient
diff --git a/src/GraphQL.Client.LocalExecution/ServiceCollectionExtensions.cs b/src/GraphQL.Client.LocalExecution/ServiceCollectionExtensions.cs
@@ -11,7 +11,7 @@ public static class ServiceCollectionExtensions
         public static IGraphQLBuilder AddGraphQLLocalExecutionClient<TSchema>(this IServiceCollection services) where TSchema : ISchema
         {
             services.AddSingleton<GraphQLLocalExecutionClient<TSchema>>();
-            services.AddSingleton<IGraphQLClient, GraphQLLocalExecutionClient<TSchema>>();
+            services.AddSingleton<IGraphQLClient>(p => p.GetRequiredService<GraphQLLocalExecutionClient<TSchema>>());
             return services.AddGraphQL();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ public static class ServiceCollectionExtensions`
`11`	`11`	`public static IGraphQLBuilder AddGraphQLLocalExecutionClient<TSchema>(this IServiceCollection services) where TSchema : ISchema`
`12`	`12`	`{`
`13`	`13`	`services.AddSingleton<GraphQLLocalExecutionClient<TSchema>>();`
`14`		`- services.AddSingleton<IGraphQLClient, GraphQLLocalExecutionClient<TSchema>>();`
	`14`	`+ services.AddSingleton<IGraphQLClient>(p => p.GetRequiredService<GraphQLLocalExecutionClient<TSchema>>());`
`15`	`15`	`return services.AddGraphQL();`
`16`	`16`	`}`
`17`	`17`	`}`