You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please correct me if I am wrong, it seems that the algorithm for pageInfo.hasPreviousPage and pageInfo.hasNextPage fields are not following with the cursor connections spec.
With current implementation, in forward pagination situation with first/after, pageInfo.hasPreviousPage is always set to false. And pageInfo.hasNextPage always false in backward pagination. In forward pagination, pageInfo.hasNextPage is only working with first and last both set, which is discouraged.
I am wondering if this deviation from the spec is intentional or is it a potential bug?
The text was updated successfully, but these errors were encountered:
Thanks for the amazing library, first of all!
Please correct me if I am wrong, it seems that the algorithm for
pageInfo.hasPreviousPage
andpageInfo.hasNextPage
fields are not following with the cursor connections spec.graphql-compose-connection/src/connectionResolver.js
Lines 338 to 339 in 29269dd
With current implementation, in forward pagination situation with
first/after
,pageInfo.hasPreviousPage
is always set tofalse
. AndpageInfo.hasNextPage
alwaysfalse
in backward pagination. In forward pagination,pageInfo.hasNextPage
is only working withfirst
andlast
both set, which is discouraged.I am wondering if this deviation from the spec is intentional or is it a potential bug?
The text was updated successfully, but these errors were encountered: