Subgraph Composition: Cache blocks processed by firehose block stream #5631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
krishna/cache-firehose-blocks
branch
2 times, most recently
from
84f8044 to
d0fff45
Compare
incrypto32
changed the base branch from
krishna/subgraph-comp-use-block-cache
to
krishna/switch-to-using-only-block-ptrs
incrypto32
force-pushed
the
krishna/cache-firehose-blocks
branch
2 times, most recently
from
fed212a to
10c5c95
Compare
incrypto32
force-pushed
the
krishna/switch-to-using-only-block-ptrs
branch
from
856f3f4 to
deaa413
Compare
incrypto32
force-pushed
the
krishna/cache-firehose-blocks
branch
from
10c5c95 to
aed6de5
Compare
incrypto32
force-pushed
the
krishna/cache-firehose-blocks
branch
from
aed6de5 to
da218ec
Compare
incrypto32
force-pushed
the
krishna/switch-to-using-only-block-ptrs
branch
from
4ad187b to
e44444f
Compare
incrypto32
force-pushed
the
krishna/cache-firehose-blocks
branch
from
da218ec to
317ce7a
Compare
mangas
reviewed
Nov 18, 2024
|
|
||
| let start_time = Instant::now(); | ||
|
|
||
| let result = chain_store |
Contributor
There was a problem hiding this comment.
Isn't this the exact responsibility of the Block Ingestor? I also don't think this should be in here because there will always be 1 stream per subgraph so this would be amplifying any write attempts or any backoffs, on top of adding more time to processing. Caching blocks is already done on the ingestor, if we need more data that's where I think it should go or if we need a healing mechanism it seems like something different.
Member
Author
There was a problem hiding this comment.
Agreed, Im closing this PR as upon evaluating, this caching is no longer required since the use of cached block ptr's which is done in a later PR
incrypto32
force-pushed
the
krishna/switch-to-using-only-block-ptrs
branch
2 times, most recently
from
fae59fa to
4c0dc41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.