Skip to content

Commit 99355c0

Browse files
Temporarily exclude RegExp & RegExpExecArray from checkNoTypeArguments for the build step to pass
1 parent 402760c commit 99355c0

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/compiler/checker.ts

+10-1
Original file line numberDiff line numberDiff line change
@@ -2288,6 +2288,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
22882288
var deferredGlobalDisposableType: ObjectType | undefined;
22892289
var deferredGlobalAsyncDisposableType: ObjectType | undefined;
22902290
var deferredGlobalRegExpSymbol: Symbol | undefined;
2291+
var deferredGlobalRegExpExecArraySymbol: Symbol | undefined; // TODO: Remove me, see `checkNoTypeArguments`
22912292
var deferredGlobalExtractSymbol: Symbol | undefined;
22922293
var deferredGlobalOmitSymbol: Symbol | undefined;
22932294
var deferredGlobalAwaitedSymbol: Symbol | undefined;
@@ -16684,7 +16685,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
1668416685
}
1668516686

1668616687
function checkNoTypeArguments(node: NodeWithTypeArguments, symbol?: Symbol) {
16687-
if (node.typeArguments) {
16688+
// Temporarily exclude these types for the build step to pass
16689+
if (node.typeArguments && symbol !== getGlobalRegExpSymbol() && symbol !== getGlobalRegExpExecArraySymbol()) {
1668816690
error(node, Diagnostics.Type_0_is_not_generic, symbol ? symbolToString(symbol) : (node as TypeReferenceNode).typeName ? declarationNameToString((node as TypeReferenceNode).typeName) : anon);
1668916691
return false;
1669016692
}
@@ -17022,6 +17024,13 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
1702217024
return deferredGlobalRegExpSymbol === unknownSymbol ? undefined : deferredGlobalRegExpSymbol;
1702317025
}
1702417026

17027+
// TODO: Remove me, see `checkNoTypeArguments`
17028+
function getGlobalRegExpExecArraySymbol(): Symbol | undefined {
17029+
// We always report an error, so cache a result in the event we could not resolve the symbol to prevent reporting it multiple times
17030+
deferredGlobalRegExpExecArraySymbol ||= getGlobalTypeAliasSymbol("RegExpExecArray" as __String, /*arity*/ 3, /*reportErrors*/ true) || unknownSymbol;
17031+
return deferredGlobalRegExpExecArraySymbol === unknownSymbol ? undefined : deferredGlobalRegExpExecArraySymbol;
17032+
}
17033+
1702517034
function getGlobalExtractSymbol(): Symbol | undefined {
1702617035
// We always report an error, so cache a result in the event we could not resolve the symbol to prevent reporting it multiple times
1702717036
deferredGlobalExtractSymbol ||= getGlobalTypeAliasSymbol("Extract" as __String, /*arity*/ 2, /*reportErrors*/ true) || unknownSymbol;

0 commit comments

Comments
 (0)