-
Notifications
You must be signed in to change notification settings - Fork 713
feat: add exemplar support to timeseries responses for individual profile retrieval #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Nov 14, 2025
…/pyroscope into api/individual-profile-retrieval
…meseries-exemplars
…' into marcsanmi/add-timeseries-exemplars
simonswine
reviewed
Nov 17, 2025
simonswine
reviewed
Nov 17, 2025
Contributor
simonswine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just focused on the query-backend for now
simonswine
added a commit
that referenced
this pull request
Nov 20, 2025
* chore: Make profileEntryIterator more configurable * Implement profileIDSelector and address review comments * Disable ID retrieval until it is used in #4615
simonswine
reviewed
Nov 20, 2025
…na/pyroscope into marcsanmi/add-timeseries-exemplars
simonswine
approved these changes
Nov 21, 2025
Contributor
simonswine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great work, thanks for going through all my comments
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements backend support for exemplars in timeseries queries.
Changes
Protobuf API
Query Pipeline
ProfileEntry.IDwithFetchProfileIDs(true)option to enable profile ID fetching only when exemplars are requestedprofileIDin legacy query pathsExemplar Management
WithoutLabels()methoda. ExemplarBuilder: Within single block
b. TimeSeriesMerger: Across blocks at same timestamp
c. RangeSeries: Across timestamps within time bucket
Merging & Aggregation
TimeSeriesMergermerges exemplars across blocks, preserving highest valuessumTimeSeriesAggregatorandavgTimeSeriesAggregatorpreserve and merge exemplars during re-aggregationPerformance Optimizations
Implementation Flow