Skip to content

Conversation

@tacole02
Copy link
Contributor

@tacole02 tacole02 commented Oct 24, 2025

This pull request adds a clarifying note to the documentation for out-of-order sample ingestion in Mimir. The note specifies the default value for the out_of_order_time_window parameter in Grafana Cloud.

Which issue(s) this PR fixes or relates to

Fixes https://github.com/grafana/support-escalations/issues/18670

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

@tacole02 tacole02 self-assigned this Oct 24, 2025
@tacole02 tacole02 requested a review from a team as a code owner October 24, 2025 18:00
@tacole02 tacole02 added type/docs Improvements or additions to documentation changelog-not-needed PRs that don't need a CHANGELOG.md entry labels Oct 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

💻 Deploy preview deleted (Docs: Add default OOO window for Grafana Cloud).

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we document Grafana Cloud elsewhere in Mimir docs? I'm a little worried that this will go out of date. I also wouldn't really expect GC customers to be reading Mimir docs. Is this a reoccurring problem we have where people read the Mimir docs and assume it applies to GC?

@56quarters
Copy link
Contributor

Reading the escalation (private repo) I see this was requested by support. I don't think this is an appropriate thing to put in the Mimir docs. Changing the default value for this setting or marking it not experimental would be fine but I don't really think we should be littering the Mimir docs with Grafana Cloud specific configuration.

@narqo
Copy link
Contributor

narqo commented Oct 27, 2025

I agree with Nick's comment. I don't know if there is a better concrete document to put them, but some existing limits are mentioned in these Grafana Cloud docs:

jesusvazquez
jesusvazquez previously approved these changes Oct 27, 2025
Copy link
Contributor

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusvazquez jesusvazquez dismissed their stale review October 27, 2025 09:15

Dismissing after reading comments in the PR

@tacole02 tacole02 closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-needed PRs that don't need a CHANGELOG.md entry type/docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants