Unprivate Service.prototype.getToken_ #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: #71 Comment:
oshliaer
commented
Sep 26, 2017
dist/OAuth2.gs
Outdated
| var token = this.parseToken_(response.getContentText()); | ||
| var resCode = response.getResponseCode(); | ||
| if ( !(resCode >= 200 && resCode < 300) || token.error) { | ||
| if ( resCode < 200 || resCode >= 300 || token.error) { |
Contributor
Author
There was a problem hiding this comment.
This happened automatically.
Contributor
|
I would prefer if this PR just included the changes to Service.gs, with the dist changes later. |
Contributor
Author
|
@erickoledadevrel , it seems that the reset to the previous commit is appropriate. |
Contributor
|
Thanks so much! |
Contributor
Author
|
Your patience helps me. Thank you too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved to public
Service.prototype.getToken_.I also commited package-lock.json file and build a new dist https://stackoverflow.com/questions/44206782
Should I split this into two pull requests?