-
Notifications
You must be signed in to change notification settings - Fork 166
test: update conformance tests to fit the new format #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update conformance tests to fit the new format #96
Conversation
| "expiration": 10, | ||
| "headers": { | ||
| "x-goog-resumable": "start" | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of changes, but in fact I've only added signingV4Tests and postPolicyV4Tests into the json structure.
|
@frankyn, teardown failed in kokoro with 403 error: |
|
Tear down should clear out all retention properties and then do Could you help improve the test code there? |
frankyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate PR for improving system tests would be much appreciated @IlyaFaer
* test: update conformance tests to fit the new format * black reformat
* test: update conformance tests to fit the new format * black reformat
Closes #92
Fields
signingV4TestsandpostPolicyV4Testswere added intourl_signer_v4_test_data.jsonto separate signing test data from POST policies test data.