fix: implement closed property on fileio.py classes #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
cojenco
reviewed
Nov 16, 2022
Contributor
cojenco
left a comment
cojenco
left a comment
There was a problem hiding this comment.
Thanks Andrew for working on this!
Could we update the unit tests, maybe an extra line of assertion in test_close and test_write? Also, do we want to apply the same changes to BlobReader? Seems like it uses the same inherited implementation.
frankyn
approved these changes
Dec 6, 2022
andrewsg
force-pushed
the
fileio-closed-property
branch
from
5432691 to
a9e6bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
_checkClosed()function withclosedproperty on fileio.py classes._checkClosed()will still work, as the inherited implementation usesself.closed.Fixes #903 🦕