Skip to content

dtype.na_value is inconsistent with returned values #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tswast opened this issue Feb 2, 2022 · 0 comments · Fixed by #67
Closed

dtype.na_value is inconsistent with returned values #66

tswast opened this issue Feb 2, 2022 · 0 comments · Fixed by #67
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Collaborator

tswast commented Feb 2, 2022

It is claimed that the na_value is NaT

python-db-dtypes-pandas/db_dtypes/core.py

Line 30 in e9d41d1

na_value = NaT

But in reality, both dbtime and dbdate return None when a missing value is present in the array.

python-db-dtypes-pandas/db_dtypes/__init__.py

Line 149 in e9d41d1

return None

python-db-dtypes-pandas/db_dtypes/__init__.py

Line 254 in e9d41d1

return None

This inconsistency is causing a few problems, such as broken __contains__ for missing values, discovered while adding compliance tests in #64
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Feb 2, 2022
@tswast tswast added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 2, 2022
@tswast tswast self-assigned this Feb 2, 2022
@tswast tswast mentioned this issue Feb 2, 2022
Merged
4 tasks
@tswast tswast closed this as completed in #67 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@tswast