Skip to content

Commit c0f9da0

Browse files
authored
test: remove redundant NIGHTLY run from CircleCI (#446)
Eventually we will want to migrate these to Kokoro (or even GitHub actions using https://github.com/google-github-actions/auth) but just remove the broken session for now. The prerelease run is redundant with the session we recently added, so replace it with a session using the latest released pandas via conda. The reason we're not removing the conda sessions completely is that pandas recommends installation via conda/mamba. Since pandas-gbq is an optional dependency of pandas, we need to ensure this package is also always installable via conda/mamba. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #424 🦕
1 parent 89078f8 commit c0f9da0

File tree

3 files changed

+20
-26
lines changed

3 files changed

+20
-26
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,20 @@ jobs:
77
# Conda
88
"conda-3.7":
99
docker:
10-
- image: continuumio/miniconda3
10+
- image: mambaorg/micromamba
1111
environment:
1212
PYTHON: "3.7"
1313
PANDAS: "0.24.2"
1414
steps:
1515
- checkout
1616
- run: ci/config_auth.sh
1717
- run: ci/run_conda.sh
18-
"conda-3.9-NIGHTLY":
18+
"conda-3.9":
1919
docker:
20-
- image: continuumio/miniconda3
20+
- image: mambaorg/micromamba
2121
environment:
2222
PYTHON: "3.9"
23-
PANDAS: "NIGHTLY"
23+
PANDAS: "1.3.4"
2424
steps:
2525
- checkout
2626
- run: ci/config_auth.sh
@@ -31,4 +31,4 @@ workflows:
3131
build:
3232
jobs:
3333
- "conda-3.7"
34-
- "conda-3.9-NIGHTLY"
34+
- "conda-3.9"
Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1+
codecov
2+
coverage
13
db-dtypes
2-
pydata-google-auth
4+
fastavro
5+
flake8
36
google-cloud-bigquery
47
google-cloud-bigquery-storage
8+
numpy
59
pyarrow
10+
pydata-google-auth
611
pytest
712
pytest-cov
8-
codecov
9-
coverage
10-
flake8
13+
tqdm

ci/run_conda.sh

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,16 @@
66
set -e -x
77
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
88

9-
# Install dependencies using Conda
9+
eval "$(micromamba shell hook --shell=bash)"
10+
micromamba activate
1011

11-
conda config --set always_yes yes --set changeps1 no
12-
conda config --add channels pandas
13-
conda config --add channels conda-forge
14-
conda update -q conda
15-
conda info -a
16-
conda create -q -n test-environment python=$PYTHON
17-
source activate test-environment
12+
# Install dependencies using (micro)mamba
13+
# https://github.com/mamba-org/micromamba-docker
1814
REQ="ci/requirements-${PYTHON}-${PANDAS}"
19-
conda install -q --file "$REQ.conda";
20-
21-
if [[ "$PANDAS" == "NIGHTLY" ]]; then
22-
conda install -q numpy pytz python-dateutil;
23-
PRE_WHEELS="https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com";
24-
pip install --pre --upgrade --timeout=60 -f $PRE_WHEELS pandas;
25-
else
26-
conda install -q pandas=$PANDAS;
27-
fi
15+
micromamba install -q pandas=$PANDAS python=${PYTHON} -c conda-forge;
16+
micromamba install -q --file "$REQ.conda" -c conda-forge;
17+
micromamba list
18+
micromamba info
2819

2920
python setup.py develop --no-deps
3021

0 commit comments

Comments
 (0)