fix: reduce bigquery table modification via DML for to_gbq #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_togbqmerge
branch
2 times, most recently
from
056c6c8 to
5180abb
Compare
product-auto-label
bot
added
size: l
chelsea-lin
changed the title
chelsea-lin
force-pushed
the
main_chelsealin_togbqmerge
branch
from
5180abb to
1c32d28
Compare
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_togbqmerge
branch
from
1c32d28 to
d8ce12f
Compare
tswast
reviewed
May 16, 2025
| for field in table_schema: | ||
| if field.name not in schema.names: | ||
| return False | ||
| if bigframes.dtypes.convert_schema_field(field)[1] != schema.get_type( |
There was a problem hiding this comment.
Do we need to do anything special here for the duration/timedelta type that we added recently?
There was a problem hiding this comment.
convert_schema_field() is able handle timedelta:
python-bigquery-dataframes/bigframes/dtypes.py
Lines 717 to 722 in d937be0
I believe we are good
tswast
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid exceeding BigQuery's 1500 daily table modification limit,
to_gbqnow prioritizesINSERTorMERGEDMLs. This method is used when the target table exists and shares the same schema, supporting both data replacement and appending. If schema discrepancies are found,to_gbqwill default back to its original table modification process.Fixes internal issue 409086472 🦕