Skip to content

feat: support to_strip parameter for str.strip, str.lstrip and str.rstrip #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

chelsea-lin
Copy link
Contributor

This update introduces to_strip parameters for the str.strip, str.lstrip, and str.rstrip methods. Additionally, it resolves an issue where newlines were not stripped when to_strip was None, ensuring compatibility with pandas behavior.

Fixes internal issue 416077777🦕

@chelsea-lin chelsea-lin requested review from a team as code owners May 7, 2025 21:48
@chelsea-lin chelsea-lin requested a review from jialuoo May 7, 2025 21:48
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 7, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_strip branch from 2c5153d to bd54203 Compare May 7, 2025 23:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 7, 2025
@jialuoo
Copy link
Contributor

jialuoo commented May 7, 2025

One of the Kokoro doctest failed, please fix it first.

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_strip branch from bd54203 to e162bcb Compare May 8, 2025 00:13
@chelsea-lin chelsea-lin merged commit a84ee75 into main May 8, 2025
20 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_strip branch May 8, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants