feat: expose BucketInfo.getProject as a BigInteger #3119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
BenWhitehead
force-pushed
the
feat/bucket-project
branch
from
bec35cd to
2701269
Compare
Expose publicly the project field which was previously internal only. This field represents the project number of the project the bucket belongs to. This field is still OUTPUT_ONLY, and as such does hot have a setter exposed for it. Fixes #3023
BenWhitehead
force-pushed
the
feat/bucket-project
branch
from
2701269 to
cc60695
Compare
BenWhitehead
commented
May 27, 2025
| @@ -328,7 +328,7 @@ public void storage_BucketGetOption_fields_BucketField() { | |||
| "website", | |||
| "softDeletePolicy", | |||
| "hierarchicalNamespace", | |||
| "website"); | |||
| "projectNumber"); | |||
There was a problem hiding this comment.
website was defined twice, changing the second one to our new expected value.
BenWhitehead
commented
May 27, 2025
| @@ -821,7 +821,7 @@ public void storage_BucketListOption_fields_BucketField() { | |||
| "items/website", | |||
| "items/softDeletePolicy", | |||
| "items/hierarchicalNamespace", | |||
| "items/website"); | |||
| "items/projectNumber"); | |||
There was a problem hiding this comment.
website was defined twice, changing the second one to our new expected value.
bajajneha27
reviewed
May 28, 2025
| @@ -2007,7 +2008,10 @@ public Builder setName(String name) { | |||
| } | |||
|
|
|||
| @Override | |||
| Builder setProject(String project) { | |||
| Builder setProject(BigInteger project) { | |||
There was a problem hiding this comment.
Should we name it set/getProjectNumber to make it more clear?
There was a problem hiding this comment.
In the v2/storage.proto it's named project in the discovery doc it's named projectNumber. Rather annoying.
We first added this field internally when doing the gRPC effort and before projectNUmber was public. In this case, I'm simply exposing the getter for the field we already have plumbed around.
bajajneha27
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose publicly the project field which was previously internal only. This field represents the project number of the project the bucket belongs to.
This field is still OUTPUT_ONLY, and as such does hot have a setter exposed.
Fixes #3023