From dc16bf96b53491d2c2c61ae657d389dd7037a42d Mon Sep 17 00:00:00 2001 From: losalex Date: Thu, 31 Mar 2022 10:33:03 -0700 Subject: [PATCH 1/2] fix: Async logging should not rethrow error in onFailure callback correction --- .../src/main/java/com/google/cloud/logging/LoggingImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java index eac372e62..c75658c11 100644 --- a/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java +++ b/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java @@ -882,7 +882,7 @@ public void flush() { try { ApiFutures.allAsList(writesToFlush).get(FLUSH_WAIT_TIMEOUT_SECONDS, TimeUnit.SECONDS); } catch (InterruptedException | ExecutionException | TimeoutException e) { - System.err.println("ERROR: flush failure: " + e); + throw new RuntimeException(e); } } @@ -940,7 +940,7 @@ public void onSuccess(Void v) { public void onFailure(Throwable t) { try { Exception ex = t instanceof Exception ? (Exception) t : new Exception(t); - throw new RuntimeException(ex); + System.err.println("ERROR: onFailure exception: " + ex); } finally { removeFromPending(); } From c7b61a3d760e0bc4bc2e6dd911013d0f4a6284f5 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 31 Mar 2022 17:37:24 +0000 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20po?= =?UTF-8?q?st-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ba7b60e06..e930bdece 100644 --- a/README.md +++ b/README.md @@ -51,7 +51,7 @@ If you are using Maven without BOM, add this to your dependencies: If you are using Gradle 5.x or later, add this to your dependencies ```Groovy -implementation platform('com.google.cloud:libraries-bom:25.0.0') +implementation platform('com.google.cloud:libraries-bom:25.1.0') implementation 'com.google.cloud:google-cloud-logging' ```