From ca74a4a329b4af3e865cd2148063f1f07586e842 Mon Sep 17 00:00:00 2001 From: Danny Hermes Date: Mon, 22 Aug 2016 13:59:29 -0700 Subject: [PATCH] Adding 429 retry in storage for bucket create and delete. --- system_tests/storage.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/system_tests/storage.py b/system_tests/storage.py index 2b46b7d11ded..aeac1c34af83 100644 --- a/system_tests/storage.py +++ b/system_tests/storage.py @@ -30,6 +30,7 @@ from retry import RetryErrors +retry_429 = RetryErrors(exceptions.TooManyRequests) HTTP = httplib2.Http() _helpers.PROJECT = TESTS_PROJECT @@ -49,7 +50,8 @@ def setUpModule(): bucket_name = 'new' + unique_resource_id() # In the **very** rare case the bucket name is reserved, this # fails with a ConnectionError. - Config.TEST_BUCKET = Config.CLIENT.create_bucket(bucket_name) + Config.TEST_BUCKET = Config.CLIENT.bucket(bucket_name) + retry_429(Config.TEST_BUCKET.create)() def tearDownModule(): @@ -65,7 +67,8 @@ def setUp(self): def tearDown(self): with Config.CLIENT.batch(): for bucket_name in self.case_buckets_to_delete: - Config.CLIENT.bucket(bucket_name).delete() + bucket = Config.CLIENT.bucket(bucket_name) + retry_429(bucket.delete)() def test_create_bucket(self): new_bucket_name = 'a-new-bucket' + unique_resource_id('-') @@ -83,7 +86,8 @@ def test_list_buckets(self): ] created_buckets = [] for bucket_name in buckets_to_create: - bucket = Config.CLIENT.create_bucket(bucket_name) + bucket = Config.CLIENT.bucket(bucket_name) + retry_429(bucket.create)() self.case_buckets_to_delete.append(bucket_name) # Retrieve the buckets.