diff --git a/gcloud/logging/metric.py b/gcloud/logging/metric.py index cc8d4d783329..3f5c95c3809d 100644 --- a/gcloud/logging/metric.py +++ b/gcloud/logging/metric.py @@ -145,3 +145,16 @@ def update(self, client=None): if self.description: data['description'] = self.description client.connection.api_request(method='PUT', path=self.path, data=data) + + def delete(self, client=None): + """API call: delete a metric via a DELETE request + + See + https://cloud.google.com/logging/docs/api/ref_v2beta1/rest/v2beta1/projects.metrics/delete + + :type client: :class:`gcloud.logging.client.Client` or ``NoneType`` + :param client: the client to use. If not passed, falls back to the + ``client`` stored on the current metric. + """ + client = self._require_client(client) + client.connection.api_request(method='DELETE', path=self.path) diff --git a/gcloud/logging/test_metric.py b/gcloud/logging/test_metric.py index a592176a7084..43f5b1efb2ec 100644 --- a/gcloud/logging/test_metric.py +++ b/gcloud/logging/test_metric.py @@ -199,6 +199,31 @@ def test_update_w_alternate_client(self): self.assertEqual(req['path'], '/%s' % FULL) self.assertEqual(req['data'], RESOURCE) + def test_delete_w_bound_client(self): + FULL = 'projects/%s/metrics/%s' % (self.PROJECT, self.METRIC_NAME) + conn = _Connection({}) + CLIENT = _Client(project=self.PROJECT, connection=conn) + metric = self._makeOne(self.METRIC_NAME, self.FILTER, client=CLIENT) + metric.delete() + self.assertEqual(len(conn._requested), 1) + req = conn._requested[0] + self.assertEqual(req['method'], 'DELETE') + self.assertEqual(req['path'], '/%s' % FULL) + + def test_delete_w_alternate_client(self): + FULL = 'projects/%s/metrics/%s' % (self.PROJECT, self.METRIC_NAME) + conn1 = _Connection() + CLIENT1 = _Client(project=self.PROJECT, connection=conn1) + conn2 = _Connection({}) + CLIENT2 = _Client(project=self.PROJECT, connection=conn2) + metric = self._makeOne(self.METRIC_NAME, self.FILTER, client=CLIENT1) + metric.delete(client=CLIENT2) + self.assertEqual(len(conn1._requested), 0) + self.assertEqual(len(conn2._requested), 1) + req = conn2._requested[0] + self.assertEqual(req['method'], 'DELETE') + self.assertEqual(req['path'], '/%s' % FULL) + class _Connection(object):