From 39b4c8930a6b5c0646d864bac34dba785055d841 Mon Sep 17 00:00:00 2001 From: Hector Rovira Date: Wed, 20 Jan 2016 11:33:42 -0600 Subject: [PATCH 1/3] added info as per CONTRIBUTORS.md --- CONTRIBUTORS | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index b6bb54b4ba1..9e8cf519004 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -18,3 +18,4 @@ Patrick Costello Silvano Luciani Stephen Sawchuk Anand Suresh +Hector Rovira From 13a268eca71b2848fa7e24f60caa5642fe9bcf62 Mon Sep 17 00:00:00 2001 From: Hector Rovira Date: Wed, 20 Jan 2016 11:35:05 -0600 Subject: [PATCH 2/3] fixing duplicated parameter description there were duplicated parameter definitions for 'err', 'callback.entities', 'callback.nextQuery', 'callback.apiResponse'. fixed by removing redundant. fixes #1074 --- lib/datastore/request.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/datastore/request.js b/lib/datastore/request.js index 30f2b964586..cb2db7f83fe 100644 --- a/lib/datastore/request.js +++ b/lib/datastore/request.js @@ -552,18 +552,10 @@ DatastoreRequest.prototype.delete = function(keys, callback) { * stream instance is returned. * @param {?error} callback.err - An error returned while making this request * (may be null). - * @param {array} callback.entities - The list of entities returned by this - * query. Note that this is a single page of entities, not necessarily - * all of the entities. + * @param {module:datastore/entity[]} callback.entities - A list of Entities * @param {?module:datastore/query} callback.nextQuery - If present, run another * query with this object to check for more results. * @param {object} callback.apiResponse - The full API response. - * @param {?error} callback.err - An error returned while making this request - * @param {object[]} callback.entities - A list of entity objects which match - * the provided keys. - * @param {?object} callback.nextQuery - If present, query with this object to - * check for more results. - * @param {object} callback.apiResponse - The full API response. * * @example * //- From 35f5cf7aecdc4af6cb077ff564f4c24d3f2c87fc Mon Sep 17 00:00:00 2001 From: Hector Rovira Date: Wed, 20 Jan 2016 11:41:42 -0600 Subject: [PATCH 3/3] fixing comments --- lib/datastore/request.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/datastore/request.js b/lib/datastore/request.js index cb2db7f83fe..2dca831c39a 100644 --- a/lib/datastore/request.js +++ b/lib/datastore/request.js @@ -552,7 +552,8 @@ DatastoreRequest.prototype.delete = function(keys, callback) { * stream instance is returned. * @param {?error} callback.err - An error returned while making this request * (may be null). - * @param {module:datastore/entity[]} callback.entities - A list of Entities + * @param {object[]} callback.entities - A list of entity objects which match + * the provided keys. * @param {?module:datastore/query} callback.nextQuery - If present, run another * query with this object to check for more results. * @param {object} callback.apiResponse - The full API response.