feat: add metrics (part 1) #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeitzman
reviewed
May 22, 2023
wangyutongg
reviewed
May 23, 2023
aeitzman
approved these changes
May 23, 2023
arithmetic1728
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This was referenced May 23, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 25, 2023
This PR adds `x-goog-api-client` header to - access token and id token refresh requests, for compute engine credentials / user credentials / service account credentials / impersonated credentials - reauth start and continue requests - metadata server ping requests Previous PRs: Part 1: #1298 Part 2: #1303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(1) list the metrics values needed
(2) add the
_metric_header_for_usagemethod to the base credential class, which is used by thebefore_requestmethod to add the metrics header for token usage. Children credentials classes can override this method for token usage metrics.internal doc: go/googleapis-auth-metric-design