Skip to content

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented May 4, 2024

This may fix the test failures in rust-random/rand#1446

@joshlf joshlf requested a review from jswrenn May 4, 2024 19:51
@joshlf joshlf force-pushed the release-0-7-33 branch from b15dbc4 to 9a18ddf Compare May 4, 2024 19:55
@joshlf joshlf enabled auto-merge May 4, 2024 19:55
@joshlf joshlf force-pushed the release-0-7-33 branch 3 times, most recently from 9348c73 to cd422dd Compare May 4, 2024 20:12
@joshlf joshlf force-pushed the release-0-7-33 branch from cd422dd to 232a00c Compare May 4, 2024 22:09
@joshlf
Copy link
Member Author

joshlf commented May 4, 2024

The remaining failing tests are cargo-semver-checks on nightly with --all-features enabled, which is attempting to build 0.7.32 (published on crates.io) with the simd-nightly feature, which in turn enables nightly compiler features which changed since 0.7.32 was published.

Discussed offline with @jswrenn, and we decided it made sense to manually override those tests and merge.

@joshlf joshlf disabled auto-merge May 4, 2024 22:19
@joshlf joshlf merged commit 370f22f into v0.7.x May 4, 2024
@joshlf joshlf deleted the release-0-7-33 branch May 4, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants