Allow gradients on QArray #131
Open
+206
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a new approach to associate gradients with QArray. The outcome is we could define vjp rules for `quantize` and `dot_general` separately while ensuring a correct backward pass. PiperOrigin-RevId: 823246141
copybara-service
bot
force-pushed
the
test_823246141
branch
from
6ed6d54 to
e594966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow gradients on QArray
This patch introduces a new approach to associate gradients with QArray. The outcome is we could define vjp rules for
quantizeanddot_generalseparately while ensuring a correct backward pass.