Skip to content

Commit bc30782

Browse files
committed
Apply review suggestions
1 parent 706a6db commit bc30782

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

github/github-accessors.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

github/github-accessors_test.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

github/repos_pages.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ type PagesBuild struct {
4747
UpdatedAt *Timestamp `json:"updated_at,omitempty"`
4848
}
4949

50-
// PagesDomain represents a domain associated with a Github Pages site.
50+
// PagesDomain represents a domain associated with a GitHub Pages site.
5151
type PagesDomain struct {
5252
Host *string `json:"host,omitempty"`
5353
URI *string `json:"uri,omitempty"`
@@ -58,7 +58,7 @@ type PagesDomain struct {
5858
IsFastlyIP *bool `json:"is_fastly_ip,omitempty"`
5959
IsOldIPAddress *bool `json:"is_old_ip_address,omitempty"`
6060
IsARecord *bool `json:"is_a_record,omitempty"`
61-
HasCNAMERecordPresent *bool `json:"has_cname_record,omitempty"`
61+
HasCNAMERecord *bool `json:"has_cname_record,omitempty"`
6262
HasMXRecordsPresent *bool `json:"has_mx_records_present,omitempty"`
6363
IsValidDomain *bool `json:"is_valid_domain,omitempty"`
6464
IsApexDomain *bool `json:"is_apex_domain,omitempty"`
@@ -79,7 +79,7 @@ type PagesDomain struct {
7979
CAAError *string `json:"caa_error,omitempty"`
8080
}
8181

82-
// PagesHealthCheckResponse represents the response given for the health check of a Github Pages site.
82+
// PagesHealthCheckResponse represents the response given for the health check of a GitHub Pages site.
8383
type PagesHealthCheckResponse struct {
8484
Domain *PagesDomain `json:"domain,omitempty"`
8585
AltDomain *PagesDomain `json:"alt_domain,omitempty"`

github/repos_pages_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ func TestPagesHealthCheckResponse_Marshal(t *testing.T) {
621621
IsFastlyIP: Bool(false),
622622
IsOldIPAddress: Bool(false),
623623
IsARecord: Bool(true),
624-
HasCNAMERecordPresent: Bool(false),
624+
HasCNAMERecord: Bool(false),
625625
HasMXRecordsPresent: Bool(false),
626626
IsValidDomain: Bool(true),
627627
IsApexDomain: Bool(true),

0 commit comments

Comments
 (0)