-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ES6 circular dependencies #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think we have a good answer for this right now. (We do for goog.module though) If you can, move both classes into a single module? Lots of Google code has one class per file (like Java) and as modules become more common I've been encouraging people to move away from that where it makes sense. |
Is this something that's going to be fixed in future versions? |
For goog.module, I believe you |
I ran into this issue as well. https://github.com/moment/moment/blob/develop/src/lib/create/from-string.js import { configFromStringAndFormat } from './from-string-and-format'; https://github.com/moment/moment/blob/develop/src/lib/create/from-string-and-format.js import { configFromISO, configFromRFC2822 } from './from-string'; |
@ChadKillingsworth is this on your radar? Maybe I'll take a stab at it? |
No not really. Have at it. |
@MatrixFrog Can you give a small example of this? |
Contrived example, but here you go. https://github.com/MatrixFrog/closure-module-example |
Running into this issue as well. For my project this mainly happens with type annotations, so I've adopted the C-style solution of generating "header" interface files declaring the public API (using But then there are a few places where there's a circular reference in type annotations on public methods as well, so I've had to pick one to remove the type checks from (replacing the |
Uh oh!
There was an error while loading. Please reload this page.
I have the following files
on compiling in Advanced mode I get this error:
Is this a bug or am I doing something wrong? If I comment the import line in test2.js it compiles but not with the result I want:
The text was updated successfully, but these errors were encountered: