Skip to content

Fixes DeprecationWarning when using .send method #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fixes DeprecationWarning when using .send method #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55501a3
Fixes issue https://github.com/google/adk-python/issues/2393
SanjaySiddharth Nov 1, 2025
276a35f
Updated Unit Tests
SanjaySiddharth Nov 1, 2025
61d9408
Merge branch 'main' into fix-dep-session.send
hangfei Nov 2, 2025
5d9e21d
Merge branch 'main' into fix-dep-session.send
hangfei Nov 5, 2025
a7f5035
Merge branch 'main' into fix-dep-session.send
hangfei Nov 5, 2025
9f6ec5a
Format assertion for send_realtime_input call
hangfei Nov 5, 2025
b23b641
Merge branch 'main' into fix-dep-session.send
hangfei Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/google/adk/models/gemini_llm_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,15 @@ async def send_realtime(self, input: RealtimeInput):
input: The input to send to the model.
"""
if isinstance(input, types.Blob):
input_blob = input.model_dump()
# The blob is binary and is very large. So let's not log it.
logger.debug('Sending LLM Blob.')
await self._gemini_session.send(input=input_blob)

logger.debug('Sending LLM Blob: %s', input)
await self._gemini_session.send_realtime_input(media=input)
Copy link

@gemini-code-assist gemini-code-assist bot Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change to use send_realtime_input is correct for handling types.Blob, the associated unit test has not been updated. The test test_send_realtime_default_behavior in tests/unittests/models/test_gemini_llm_connection.py still asserts that mock_gemini_session.send is called, which will now fail.

Please update the test to verify that mock_gemini_session.send_realtime_input is called instead. Here is a suggested update for the test:

@pytest.mark.asyncio
async def test_send_realtime_blob(gemini_connection, mock_gemini_session, test_blob):
  """Test send_realtime with a blob."""
  await gemini_connection.send_realtime(test_blob)

  mock_gemini_session.send_realtime_input.assert_called_once_with(media=test_blob)
  mock_gemini_session.send.assert_not_called()

Failing to update tests alongside code changes can lead to a brittle test suite and hide potential regressions.

Copy link
Contributor Author

@SanjaySiddharth SanjaySiddharth Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! This is done ! Thanks

Copy link
Collaborator

@hangfei hangfei Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help explain why we migrate to this method and not others:
("Please use one of the more specific methods: send_client_content, send_realtime_input, or send_tool_response instead.
await self._gemini_session.send(input=input_blob)")


# input_blob = input.model_dump()
# # The blob is binary and is very large. So let's not log it.
# logger.debug('Sending LLM Blob.')
# await self._gemini_session.send(input=input_blob)

elif isinstance(input, types.ActivityStart):
logger.debug('Sending LLM activity start signal.')
await self._gemini_session.send_realtime_input(activity_start=input)
Expand Down
6 changes: 5 additions & 1 deletion tests/unittests/models/test_gemini_llm_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ async def test_send_realtime_default_behavior(
await gemini_connection.send_realtime(test_blob)

# Should call send once
mock_gemini_session.send.assert_called_once_with(input=test_blob.model_dump())
mock_gemini_session.send_realtime_input.assert_called_once_with(
media=test_blob
)
# Should not call .send function
mock_gemini_session.send.assert_not_called()


@pytest.mark.asyncio
Expand Down
Loading