Skip to content

Commit 41b25ce

Browse files
authored
Make "wait" default to false (#583)
This was an unintentional breaking change, but we didn't catch it because GitHub changed how floating tags work. - Closes #578 - Closes #579
1 parent e1b1b0b commit 41b25ce

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ jobs:
203203
- <a name="__input_no_traffic"></a><a href="#user-content-__input_no_traffic"><code>no_traffic</code></a>: _(Optional, default: `false`)_ If true, the newly deployed revision will not receive traffic. This option
204204
only applies to services.
205205

206-
- <a name="__input_wait"></a><a href="#user-content-__input_wait"><code>wait</code></a>: _(Optional, default: `true`)_ If true, the action will wait for the job to complete before exiting. This
207-
option only applies to jobs.
206+
- <a name="__input_wait"></a><a href="#user-content-__input_wait"><code>wait</code></a>: _(Optional, default: `false`)_ If true, the action will execute and wait for the job to complete before
207+
exiting. This option only applies to jobs.
208208

209209
- <a name="__input_revision_traffic"></a><a href="#user-content-__input_revision_traffic"><code>revision_traffic</code></a>: _(Optional)_ Comma-separated list of revision traffic assignments.
210210

action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,9 @@ inputs:
220220

221221
wait:
222222
description: |-
223-
If true, the action will wait for the job to complete before exiting. This
224-
option only applies to jobs.
225-
default: 'true'
223+
If true, the action will execute and wait for the job to complete before
224+
exiting. This option only applies to jobs.
225+
default: 'false'
226226
required: false
227227

228228
revision_traffic:

0 commit comments

Comments
 (0)