From 9e562b3c292c6a9aa42022a6f76126230a0607f4 Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Thu, 21 Jun 2018 09:54:15 +0300 Subject: [PATCH 1/7] just testing --- app/analyze/processors/github_go_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/app/analyze/processors/github_go_test.go b/app/analyze/processors/github_go_test.go index 19734ac..7796f63 100644 --- a/app/analyze/processors/github_go_test.go +++ b/app/analyze/processors/github_go_test.go @@ -45,6 +45,14 @@ var testPR = &gh.PullRequest{ } var testAnalysisGUID = "test-guid" +func badFunc() { + if true { + return + } else { + getNopFetcher(nil) + } +} + func getFakeLinters(ctrl *gomock.Controller, issues ...result.Issue) []linters.Linter { a := linters.NewMockLinter(ctrl) a.EXPECT(). From 85e11e6d6770ed4ed17853a48c3a5608db93e8d8 Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Thu, 21 Jun 2018 10:08:04 +0300 Subject: [PATCH 2/7] fix --- app/analyze/processors/github_go_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/analyze/processors/github_go_test.go b/app/analyze/processors/github_go_test.go index 7796f63..d3b6cc8 100644 --- a/app/analyze/processors/github_go_test.go +++ b/app/analyze/processors/github_go_test.go @@ -45,12 +45,11 @@ var testPR = &gh.PullRequest{ } var testAnalysisGUID = "test-guid" -func badFunc() { +func BadFunc() { if true { return - } else { - getNopFetcher(nil) } + getNopFetcher(nil) } func getFakeLinters(ctrl *gomock.Controller, issues ...result.Issue) []linters.Linter { From 9e1255c90aeb518166de87a7558970f9e4cef2bf Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Thu, 21 Jun 2018 10:10:31 +0300 Subject: [PATCH 3/7] fix --- app/analyze/processors/github_go_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/analyze/processors/github_go_test.go b/app/analyze/processors/github_go_test.go index d3b6cc8..3e5d52d 100644 --- a/app/analyze/processors/github_go_test.go +++ b/app/analyze/processors/github_go_test.go @@ -52,6 +52,10 @@ func BadFunc() { getNopFetcher(nil) } +func init() { + BadFunc() +} + func getFakeLinters(ctrl *gomock.Controller, issues ...result.Issue) []linters.Linter { a := linters.NewMockLinter(ctrl) a.EXPECT(). From b9f2cfda1d1ba25a8bfe1189f0286b121310eba9 Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Sun, 24 Jun 2018 14:59:41 +0300 Subject: [PATCH 4/7] add bad file --- app/bad.go | 1 + 1 file changed, 1 insertion(+) create mode 100644 app/bad.go diff --git a/app/bad.go b/app/bad.go new file mode 100644 index 0000000..e756e6f --- /dev/null +++ b/app/bad.go @@ -0,0 +1 @@ +trash is here From 2dd4cf532f357c46ed5f195195437a7307e66724 Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Sun, 24 Jun 2018 15:15:27 +0300 Subject: [PATCH 5/7] mv --- {app => badpkg}/bad.go | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {app => badpkg}/bad.go (100%) diff --git a/app/bad.go b/badpkg/bad.go similarity index 100% rename from app/bad.go rename to badpkg/bad.go From b9fed31383695626fbeb4f6f0696c32fa71c01e6 Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Sun, 24 Jun 2018 15:18:25 +0300 Subject: [PATCH 6/7] issues --- app/analyze/processors/github_go_test.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/app/analyze/processors/github_go_test.go b/app/analyze/processors/github_go_test.go index 3e5d52d..83f288f 100644 --- a/app/analyze/processors/github_go_test.go +++ b/app/analyze/processors/github_go_test.go @@ -45,15 +45,12 @@ var testPR = &gh.PullRequest{ } var testAnalysisGUID = "test-guid" -func BadFunc() { + func BadFunc() { if true { return - } - getNopFetcher(nil) -} - -func init() { - BadFunc() + } else { + getNopFetcher(nil) + } } func getFakeLinters(ctrl *gomock.Controller, issues ...result.Issue) []linters.Linter { From fbd0d7bada8a6cfa7adbc58e5901e0d66f7f65b1 Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Sun, 24 Jun 2018 15:23:45 +0300 Subject: [PATCH 7/7] more issues --- app/analyze/processors/github_go_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/app/analyze/processors/github_go_test.go b/app/analyze/processors/github_go_test.go index 83f288f..c18ea99 100644 --- a/app/analyze/processors/github_go_test.go +++ b/app/analyze/processors/github_go_test.go @@ -53,6 +53,14 @@ var testAnalysisGUID = "test-guid" } } + func BadFunc2() { + if false { + return + } else { + getNopFetcher(nil) + } +} + func getFakeLinters(ctrl *gomock.Controller, issues ...result.Issue) []linters.Linter { a := linters.NewMockLinter(ctrl) a.EXPECT().