Skip to content

Broken link to unused linter in README #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbandy opened this issue Aug 27, 2019 · 1 comment
Closed

Broken link to unused linter in README #654

cbandy opened this issue Aug 27, 2019 · 1 comment
Labels
area: docs

Comments

@cbandy
Copy link
Contributor

cbandy commented Aug 27, 2019

EnabledByDefaultLinters section of README links to https://github.com/dominikh/go-tools/tree/master/cmd/unused which was removed in dominikh/go-tools@a1e4860.

(The commit message there makes it sound like the unused functionality has changed.)
@vovapi
Copy link
Contributor

vovapi commented Sep 12, 2019 •
edited
Loading

It seems that the fork of go-tools (https://github.com/golangci/go-tools) is actually used:

golangci-lint/go.mod

Line 18 in 2e8d832

github.com/golangci/go-tools v0.0.0-20190318055746-e32c54105b7c

I think README should point there.

@jirfag jirfag closed this as completed in d63d235 Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbandy @tpounds @vovapi