-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Feature] TODO/FIXME linter #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jirfag may I please request your opinion on this? |
@matoous I would love to have this! I have built up a fair amount of tech debt from people adding TODOs to pion/webrtc so anything I can do to help get this merged please tell me :) |
@matoous I am not able to open issues against your repo because it is a fork. But would you be ok accepting a PR that sets a non-zero error code when there are results? It would be much easier for me to use in travis if I can just throw an error on non-zero. thanks |
Sure! Merged it. I am now away for 3 weeks but when I am back I will try to submit PR for this. |
Had some time, so here's the PR #621 |
Hi, it's merged, thank you |
New linters should be not enabled by default, since it is an incompatible upgrade. |
@douglarek what are you talking about? godox isn't enabled by default |
Uh oh!
There was an error while loading. Please reload this page.
Add https://github.com/matoous/godox to linters (I wanted to create an issue for adding https://github.com/766b/godox but I didn't like the code so I hope this fork is ok). I will gladly create PR if this is approved.
The text was updated successfully, but these errors were encountered: