Skip to content

[Feature] TODO/FIXME linter #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matoous opened this issue May 27, 2019 · 8 comments
Closed

[Feature] TODO/FIXME linter #547

matoous opened this issue May 27, 2019 · 8 comments
Labels
linter: new Support new linter

Comments

@matoous
Copy link
Contributor

matoous commented May 27, 2019

Add https://github.com/matoous/godox to linters (I wanted to create an issue for adding https://github.com/766b/godox but I didn't like the code so I hope this fork is ok). I will gladly create PR if this is approved.

@matoous
Copy link
Contributor Author

matoous commented Jul 17, 2019

@jirfag may I please request your opinion on this?

@Sean-Der
Copy link
Contributor

@matoous
Have you tried adding it to golangci-lint? It might get accepted quicker/easier if the code is ready to merge!

I would love to have this! I have built up a fair amount of tech debt from people adding TODOs to pion/webrtc so anything I can do to help get this merged please tell me :)

@Sean-Der
Copy link
Contributor

@matoous I am not able to open issues against your repo because it is a fork.

But would you be ok accepting a PR that sets a non-zero error code when there are results? It would be much easier for me to use in travis if I can just throw an error on non-zero.

thanks

@matoous
Copy link
Contributor Author

matoous commented Jul 20, 2019

Sure! Merged it. I am now away for 3 weeks but when I am back I will try to submit PR for this.

@matoous
Copy link
Contributor Author

matoous commented Jul 21, 2019

Had some time, so here's the PR #621

@jirfag
Copy link
Contributor

jirfag commented Sep 11, 2019

Hi, it's merged, thank you

@matoous matoous closed this as completed Sep 19, 2019
@douglarek
Copy link

douglarek commented Sep 29, 2019

New linters should be not enabled by default, since it is an incompatible upgrade.

@tpounds tpounds added the linter: new Support new linter label Sep 29, 2019
@jirfag
Copy link
Contributor

jirfag commented Sep 30, 2019

@douglarek what are you talking about? godox isn't enabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

No branches or pull requests

5 participants