Typecheck runs even though it is not an enabled linter

[ewrenn8]

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've included all information below (version, config, etc).
• Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

When running with golangci-lint version 1.40.0, we are seeing that, although we have explicitly disabled all linters in our config and only enabled a few, not including typecheck, the typecheck linter is still running.

Version of golangci-lint

v0.40.0

Config file

$ cat .golangci.yml
run:
  timeout: 5m
linters:
  enable:
    - goheader
    - golint
    - deadcode
    - unused
  disable-all: true
# all available settings of specific linters
linters-settings:
  goheader:
    values:
      regexp:
        copyright-year: 202[0-1]
    template-path: code-header-template.txt
issues:
  max-issues-per-linter: 0
  max-same-issues: 0

Go environment

$ go version && go env
go version go1.16.5 linux/amd64
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/runner/.cache/go-build"
GOENV="/home/runner/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/runner/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/runner/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/hostedtoolcache/go/1.16.5/x64"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/hostedtoolcache/go/1.16.5/x64/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.5"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/runner/work/carvel-kapp-controller/carvel-kapp-controller/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3653466737=/tmp/go-build -gno-record-gcc-switches"

For context, this is not running with the bare binary, it is running in a github action. I opened the issue here, because the binary is reporting conflicting info and I figured that is not due to the action itself. Here are some potentially helpful links:

1. Binary reporting it is only using 4 linters
2. Typecheck errors even though typecheck isn't an enabled linter

If I am mistaken and this issue should be opened some place else, please let me know.

Thank you!

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

Hello,

typecheck is not a real linter, it's a way to display compilation errors reported by the other linters.

[ewrenn8]

I'm a bit confused, there are no compilation errors when compiling with the plain go compiler, so why is typecheck reporting that there are? Also, after investigating the errors, typecheck is reporting errors that don't actually exist, such as a named import not being used by its name, when it clearly is (potentially related issue #1921). Is there anything I can do to further investigate why these erroneous errors are being reported?

[ldez]

@ewrenn8 your problem is related to your vendor folder: there are some missing files.

You have to do a go mod vendor

$ golangci-lint run
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive. 
pkg/apiserver/client/clientset/versioned/typed/datapackaging/v1alpha1/fake/fake_package.go:30:3: c.Fake.Invokes undefined (type *FakeDataV1alpha1 has no field or method Invokes) (typecheck)
                Invokes(testing.NewGetAction(PackagesResource, c.ns, name), &v1alpha1.Package{})
                ^
...
pkg/apiserver/registry/datapackaging/package_metadata_crd_rest_test.go:22:2: "k8s.io/client-go/testing" imported but not used as cgtesting (typecheck)
        cgtesting "k8s.io/client-go/testing"
        ^
$ go mod vendor 
$ git status -sb
## go-version-bump...origin/go-version-bump
 D vendor/github.com/googleapis/gnostic/OpenAPIv2/OpenAPIv2.go
 D vendor/github.com/googleapis/gnostic/OpenAPIv2/OpenAPIv2.pb.go
 D vendor/github.com/googleapis/gnostic/OpenAPIv2/OpenAPIv2.proto
 D vendor/github.com/googleapis/gnostic/OpenAPIv2/README.md
 D vendor/github.com/googleapis/gnostic/OpenAPIv2/openapi-2.0.json
?? vendor/github.com/googleapis/gnostic/openapiv2/OpenAPIv2.go
?? vendor/github.com/googleapis/gnostic/openapiv2/OpenAPIv2.pb.go
?? vendor/github.com/googleapis/gnostic/openapiv2/OpenAPIv2.proto
?? vendor/github.com/googleapis/gnostic/openapiv2/README.md
?? vendor/github.com/googleapis/gnostic/openapiv2/openapi-2.0.json
$ golangci-lint run
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive. 

[aaahrens]

I would really appreciate this being fixed as it's seriously blocking bazel integration.

[ldez]

There is nothing to fix: typecheck is not real linter, it's a way to display "compilation" errors throw by linters.