Skip to content

Commit fc8b81e

Browse files
author
golangci
authored
Merge pull request #18 from golangci/feature/windows-color-support
#14: support color output on windows
2 parents bbd28f4 + eea1b93 commit fc8b81e

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

pkg/commands/linters.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77

88
"github.com/fatih/color"
99
"github.com/golangci/golangci-lint/pkg"
10+
"github.com/golangci/golangci-lint/pkg/printers"
1011
"github.com/spf13/cobra"
1112
)
1213

@@ -21,7 +22,7 @@ func (e *Executor) initLinters() {
2122

2223
func printLinterConfigs(lcs []pkg.LinterConfig) {
2324
for _, lc := range lcs {
24-
fmt.Printf("%s: %s [fast: %t]\n", color.YellowString(lc.Linter.Name()),
25+
fmt.Fprintf(printers.StdOut, "%s: %s [fast: %t]\n", color.YellowString(lc.Linter.Name()),
2526
lc.Linter.Desc(), !lc.DoesFullImport)
2627
}
2728
}
@@ -48,7 +49,7 @@ func (e Executor) executeLinters(cmd *cobra.Command, args []string) {
4849
for _, linter := range linters {
4950
linterNames = append(linterNames, linter.Name())
5051
}
51-
fmt.Printf("%s: %s\n", color.YellowString(p), strings.Join(linterNames, ", "))
52+
fmt.Fprintf(printers.StdOut, "%s: %s\n", color.YellowString(p), strings.Join(linterNames, ", "))
5253
}
5354

5455
os.Exit(0)

pkg/printers/utils.go

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
package printers
22

3-
import (
4-
"os"
5-
"syscall"
6-
)
3+
import "github.com/fatih/color"
74

8-
var StdOut = os.NewFile(uintptr(syscall.Stdout), "/dev/stdout") // was set to /dev/null
5+
var StdOut = color.Output // https://github.com/golangci/golangci-lint/issues/14

0 commit comments

Comments
 (0)