Fix #78: log all warnings

Author: jirfag

.gitignore

@@ -2,3 +2,4 @@
 /*.pprof
 /dist/
 /.idea/
+/test/path

Makefile

@@ -1,5 +1,5 @@
 test:
-	go install ./cmd/... # needed for govet and golint
+	go install ./cmd/... # needed for govet and golint if go < 1.10
 	golangci-lint run -v
 	golangci-lint run --fast --no-config -v
 	golangci-lint run --no-config -v

pkg/commands/run_config.go

@@ -9,7 +9,6 @@ import (
 
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/fsutils"
-	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/printers"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/pflag"
@@ -84,7 +83,7 @@ func setupConfigFileSearch(args []string) {
 
 	absStartPath, err := filepath.Abs(firstArg)
 	if err != nil {
-		logutils.HiddenWarnf("Can't make abs path for %q: %s", firstArg, err)
+		logrus.Warnf("Can't make abs path for %q: %s", firstArg, err)
 		absStartPath = filepath.Clean(firstArg)
 	}
 
@@ -117,13 +116,13 @@ func setupConfigFileSearch(args []string) {
 func getRelPath(p string) string {
 	wd, err := os.Getwd()
 	if err != nil {
-		logutils.HiddenWarnf("Can't get wd: %s", err)
+		logrus.Warnf("Can't get wd: %s", err)
 		return p
 	}
 
 	r, err := filepath.Rel(wd, p)
 	if err != nil {
-		logutils.HiddenWarnf("Can't make path %s relative to %s: %s", p, wd, err)
+		logrus.Warnf("Can't make path %s relative to %s: %s", p, wd, err)
 		return p
 	}
 

pkg/golinters/gas.go

@@ -11,8 +11,8 @@ import (
 	"github.com/GoASTScanner/gas"
 	"github.com/GoASTScanner/gas/rules"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
-	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/result"
+	"github.com/sirupsen/logrus"
 )
 
 type Gas struct{}
@@ -46,7 +46,7 @@ func (lint Gas) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issu
 		if err != nil {
 			r = &result.Range{}
 			if n, rerr := fmt.Sscanf(i.Line, "%d-%d", &r.From, &r.To); rerr != nil || n != 2 {
-				logutils.HiddenWarnf("Can't convert gas line number %q of %v to int: %s", i.Line, i, err)
+				logrus.Warnf("Can't convert gas line number %q of %v to int: %s", i.Line, i, err)
 				continue
 			}
 			line = r.From

pkg/golinters/golint.go

@@ -7,9 +7,9 @@ import (
 	"go/token"
 
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
-	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/result"
 	lintAPI "github.com/golangci/lint-1"
+	"github.com/sirupsen/logrus"
 )
 
 type Golint struct{}
@@ -39,7 +39,7 @@ func (g Golint) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issu
 		issues = append(issues, i...)
 	}
 	if lintErr != nil {
-		logutils.HiddenWarnf("golint: %s", lintErr)
+		logrus.Warnf("golint: %s", lintErr)
 	}
 
 	return issues, nil

pkg/lint/astcache/astcache.go

@@ -108,6 +108,9 @@ func (c *Cache) parseFile(filePath string, fset *token.FileSet) {
 		Err:  err,
 		Name: filePath,
 	}
+	if err != nil {
+		logrus.Warnf("Can't parse AST of %s: %s", filePath, err)
+	}
 }
 
 func LoadFromFiles(files []string) (*Cache, error) {

pkg/lint/runner.go

@@ -10,7 +10,6 @@ import (
 	"time"
 
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
-	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/result"
 	"github.com/golangci/golangci-lint/pkg/result/processors"
 	"github.com/golangci/golangci-lint/pkg/timeutils"
@@ -31,7 +30,7 @@ func runLinterSafe(ctx context.Context, lintCtx *linter.Context, lc linter.Confi
 	defer func() {
 		if panicData := recover(); panicData != nil {
 			err = fmt.Errorf("panic occured: %s", panicData)
-			logutils.HiddenWarnf("Panic stack trace: %s", debug.Stack())
+			logrus.Warnf("Panic stack trace: %s", debug.Stack())
 		}
 	}()
 
@@ -152,7 +151,7 @@ func (r SimpleRunner) processLintResults(ctx context.Context, inCh <-chan lintRe
 
 		for res := range inCh {
 			if res.err != nil {
-				logutils.HiddenWarnf("Can't run linter %s: %s", res.linter.Linter.Name(), res.err)
+				logrus.Warnf("Can't run linter %s: %s", res.linter.Linter.Name(), res.err)
 				continue
 			}
 
@@ -221,7 +220,7 @@ func (r *SimpleRunner) processIssues(ctx context.Context, issues []result.Issue,
 		})
 
 		if err != nil {
-			logutils.HiddenWarnf("Can't process result by %s processor: %s", p.Name(), err)
+			logrus.Warnf("Can't process result by %s processor: %s", p.Name(), err)
 		} else {
 			issues = newIssues
 		}

pkg/logutils/logutils.go

@@ -7,16 +7,6 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-var isGolangCIRun = os.Getenv("GOLANGCI_COM_RUN") == "1"
-
-func HiddenWarnf(format string, args ...interface{}) {
-	if isGolangCIRun {
-		logrus.Warnf(format, args...)
-	} else {
-		logrus.Infof(format, args...)
-	}
-}
-
 func getEnabledDebugs() map[string]bool {
 	ret := map[string]bool{}
 	debugVar := os.Getenv("GL_DEBUG")