clean code base.

Author: ldez

.golangci.yml

@@ -73,6 +73,7 @@ linters:
     - dogsled
     - dupl
     - errcheck
+    - exportloopref
     - exhaustive
     - funlen
     - gochecknoinits
@@ -94,7 +95,6 @@ linters:
     - noctx
     - nolintlint
     - rowserrcheck
-    - scopelint
     - staticcheck
     - structcheck
     - stylecheck
@@ -107,6 +107,7 @@ linters:
 
   # don't enable:
   # - asciicheck
+  # - scopelint
   # - gochecknoglobals
   # - gocognit
   # - godot

go.sum

@@ -176,7 +176,7 @@ func (p *hunkChangesParser) parse(h *diffpkg.Hunk) []Change {
 	for i := 0; i < len(p.lines); {
 		line := p.lines[i]
 		if line.typ == diffLineOriginal {
-			p.handleOriginalLine(line, &i) //nolint:scopelint
+			p.handleOriginalLine(line, &i)
 			continue
 		}
 

pkg/golinters/gofmt_common.go

@@ -57,7 +57,7 @@ func (f Fixer) Process(issues []result.Issue) []result.Issue {
 	for file, issuesToFix := range issuesToFixPerFile {
 		var err error
 		f.sw.TrackStage("all", func() {
-			err = f.fixIssuesInFile(file, issuesToFix) //nolint:scopelint
+			err = f.fixIssuesInFile(file, issuesToFix)
 		})
 		if err != nil {
 			f.log.Errorf("Failed to fix issues in file %s: %s", file, err)

pkg/result/processors/fixer.go

@@ -27,11 +27,11 @@ func TestPathPrefixer_Process(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			r := require.New(t)
 
-			p := NewPathPrefixer(tt.prefix)  //nolint:scopelint
-			got, err := p.Process(tt.issues) //nolint:scopelint
+			p := NewPathPrefixer(tt.prefix)
+			got, err := p.Process(tt.issues)
 			r.NoError(err, "prefixer should never error")
 
-			r.Equal(got, tt.want) //nolint:scopelint
+			r.Equal(got, tt.want)
 		})
 	}
 }

pkg/result/processors/path_prefixer_test.go

@@ -337,9 +337,9 @@ func TestPathPrefix(t *testing.T) {
 	} {
 		t.Run(tt.Name, func(t *testing.T) {
 			testshared.NewLintRunner(t).Run(
-				append(tt.Args, getTestDataDir("withtests"))..., //nolint:scopelint
+				append(tt.Args, getTestDataDir("withtests"))...,
 			).ExpectOutputRegexp(
-				tt.Pattern, //nolint:scopelint
+				tt.Pattern,
 			)
 		})
 	}

test/run_test.go

@@ -1,4 +1,4 @@
-//args: -Escopelint
+//args: -Escopelint --internal-cmd-test
 package testdata
 
 import "fmt"