Skip to content

Commit ad26b68

Browse files
authored
build(dep): Ignore known dependency failure in nancy (#1378)
Currently nancy is always failed, and we seem to ignore it completely. This reduces the value of having security scanning significantly. Ideally, the underlying issue should be fixed, however it will require long time for external collaboration. This commit is to ignore two known dependency failures. Signed-off-by: Tam Mach <[email protected]>
1 parent 5f93c93 commit ad26b68

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

.github/workflows/pr-extra.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
steps:
1414
- uses: actions/checkout@v2
1515
- uses: actions/setup-go@v2
16-
# We cannot use nancy-github-action because it is outdated, so it's better to use the latest
17-
# docker image for the validation
18-
- name: nancy
19-
run: go list -json -m all | docker run -i sonatypecommunity/nancy:v0.3
16+
- name: Run go list
17+
run: go list -json -m all > go.list
18+
- name: Nancy
19+
uses: sonatype-nexus-community/nancy-github-action@master

.nancy-ignore

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Skip for golang/golang.org/x/[email protected]
2+
CVE-2018-17848
3+
CVE-2018-17143
4+
CVE-2018-17847
5+
CVE-2018-17142
6+
CVE-2018-17846
7+
8+
# Skip for indirect dependency github.com/coreos/[email protected]
9+
CVE-2020-15114
10+
CVE-2020-15115
11+
CVE-2020-15136

0 commit comments

Comments
 (0)