dev: simplify mnd implementation (#5731)

Author: alexandear

pkg/golinters/mnd/mnd.go

@@ -9,11 +9,10 @@ import (
 )
 
 func New(settings *config.MndSettings) *goanalysis.Linter {
-	return newMND(mnd.Analyzer, settings, nil)
-}
+	a := mnd.Analyzer
 
-func newMND(a *analysis.Analyzer, settings *config.MndSettings, linterCfg map[string]map[string]any) *goanalysis.Linter {
-	if len(linterCfg) == 0 && settings != nil {
+	var linterCfg map[string]map[string]any
+	if settings != nil {
 		cfg := make(map[string]any)
 		if len(settings.Checks) > 0 {
 			cfg["checks"] = settings.Checks

pkg/golinters/mnd/testdata/mnd_custom.go

@@ -0,0 +1,24 @@
+//golangcitest:args -Emnd
+//golangcitest:config_path testdata/mnd_custom.yml
+package testdata
+
+import (
+	"log"
+	"net/http"
+	"time"
+)
+
+func Mnd() {
+	c := &http.Client{
+		Timeout: 5 * time.Second,
+	}
+
+	res, err := c.Get("https://www.google.com")
+	if err != nil {
+		log.Fatal(err)
+	}
+	defer res.Body.Close()
+	if res.StatusCode != 200 { // want "Magic number: 200, in <condition> detected"
+		log.Println("Something went wrong")
+	}
+}

pkg/golinters/mnd/testdata/mnd_custom.yml

@@ -0,0 +1,7 @@
+version: "2"
+
+linters:
+  settings:
+    mnd:
+      ignored-numbers:
+        - '5'