You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: README.md
+5-5
Original file line number
Diff line number
Diff line change
@@ -47,7 +47,7 @@ The recommended way to install golangci-lint:
47
47
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s VERSION
48
48
```
49
49
50
-
Periodically update version of golangci-lint: the project is under active development
50
+
Periodically update version of golangci-lint: the project is under active development
51
51
and is constantly being improved. But please always check for newly found issues and
52
52
update if needed.
53
53
@@ -137,7 +137,7 @@ GolangCI-Lint was created to fix the following issues with `gometalinter`:
137
137
3. Doesn't use real bounded concurrency: if you set it to `n` it can take up to `n*n` threads because of forced threads in specific linters. `gometalinter` can't do anything about it because it runs linters as black boxes in forked processes. In GolangCI-Lint we run all linters in one process and completely control them. Configured concurrency will be correctly bounded.
138
138
This issue is important because you often want to set concurrency to the CPUs count minus one to ensure you **do not freeze your PC** and be able to work on it while analyzing code.
139
139
4. Lack of nice output. We like how the `gcc` and `clang` compilers format their warnings: **using colors, printing warning lines and showing the position in line**.
140
-
5. Too many issues. GolangCI-Lint cuts a lot of issues by using default exclude list of common false-positives. By default, it has enables**smart issues processing**: merge multiple issues for one line, merge issues with the same text or from the same linter. All of these smart processors can be configured by the user.
140
+
5. Too many issues. GolangCI-Lint cuts a lot of issues by using default exclude list of common false-positives. By default, it has enabled**smart issues processing**: merge multiple issues for one line, merge issues with the same text or from the same linter. All of these smart processors can be configured by the user.
141
141
6. Integration into large codebases. A good way to start using linters in a large project is not to fix a plethora of existing issues, but to set up CI and **fix only issues in new commits**. You can use `revgrep` for it, but it's yet another utility to install and configure. With `golangci-lint` it's much easier: `revgrep` is already built into `golangci-lint` and you can use it with one option (`-n, --new` or `--new-from-rev`).
142
142
7. Installation. With `gometalinter`, you need to run a linters installation step. It's easy to forget this step and end up with stale linters. It also complicates CI setup. GolangCI-Lint requires **no installation of linters**.
143
143
8.**Yaml or toml config**. Gometalinter's JSON isn't convenient for config files.
@@ -150,13 +150,13 @@ This issue is important because you often want to set concurrency to the CPUs co
150
150
# Performance
151
151
Benchmarks were executed on MacBook Pro (Retina, 13-inch, Late 2013), 2,4 GHz Intel Core i5, 8 GB 1600 MHz DDR3.
152
152
It has 4 cores and concurrent linting as a default consuming all cores.
153
-
Benchmark were run (and measured) automatically, see the code
153
+
Benchmark was run (and measured) automatically, see the code
We measure peak memory usage (RSS) by tracking of processes RSS every 5 ms.
157
157
158
158
## Comparison with gometalinter
159
-
We compare golangci-lint and gometalinter in default mode, but explicitly enabl all linters because of small differences in the default configuration.
159
+
We compare golangci-lint and gometalinter in default mode, but explicitly enable all linters because of small differences in the default configuration.
160
160
```bash
161
161
$ golangci-lint run --no-config --issues-exit-code=0 --deadline=30m \
0 commit comments