update go-critic to v0.5.6 (#1925)

pierrre · web-flow · commit 8da9d3aa620b · 2021-05-01T13:41:21.000+02:00
diff --git a/go.mod b/go.mod
@@ -18,7 +18,7 @@ require (
 	github.com/esimonov/ifshort v1.0.2
 	github.com/fatih/color v1.10.0
 	github.com/fzipp/gocyclo v0.3.1
-	github.com/go-critic/go-critic v0.5.5
+	github.com/go-critic/go-critic v0.5.6
 	github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
 	github.com/gofrs/flock v0.8.0
 	github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
diff --git a/go.sum b/go.sum
diff --git a/pkg/golinters/govet_test.go b/pkg/golinters/govet_test.go
@@ -18,9 +18,10 @@ import (
 
 func TestGovet(t *testing.T) {
 	// Checking that every default analyzer is in "all analyzers" list.
-	checkList := append(defaultAnalyzers,
-		shadow.Analyzer, // special case, used in analyzersFromConfig
-	)
+	var checkList []*analysis.Analyzer
+	checkList = append(checkList, defaultAnalyzers...)
+	checkList = append(checkList, shadow.Analyzer) // special case, used in analyzersFromConfig
+
 	for _, defaultAnalyzer := range checkList {
 		found := false
 		for _, a := range allAnalyzers {

-Original file line number
+Diff line change
 	github.com/esimonov/ifshort v1.0.2
 	github.com/fatih/color v1.10.0
 	github.com/fzipp/gocyclo v0.3.1
 -	github.com/go-critic/go-critic v0.5.5
 +	github.com/go-critic/go-critic v0.5.6
 	github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
 	github.com/gofrs/flock v0.8.0
 	github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2